From: Ingo Molnar <mingo@elte.hu>
To: linux@bohmer.net
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: PI mutex support on ARM
Date: Sun, 8 Jul 2007 11:58:41 +0200 [thread overview]
Message-ID: <20070708095841.GA4601@elte.hu> (raw)
In-Reply-To: <3efb10970707080124i7a9323c5o9257b4adcb2ac493@mail.gmail.com>
* Remy Bohmer <l.pinguin@gmail.com> wrote:
> --- linux-2.6.21.orig/include/asm/futex.h 2007-04-26 05:08:32.000000000 +0200
patch format problem: never diff the asm/ files, diff the asm-arm/
files.
> + local_irq_save(flags);
> +
> + err = get_user(uval, uaddr);
is it safe to do a get_user() with irqs off?
> + if (err)
> + {
> + local_irq_restore(flags);
> + return -EFAULT;
> + }
(style problems. Use scripts/checkpatch.pl to verify your patches.)
> + local_irq_restore(flags);
is this method of atomic ops SMP-safe?
Ingo
next prev parent reply other threads:[~2007-07-08 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 8:24 PI mutex support on ARM Remy Bohmer
2007-07-08 9:58 ` Ingo Molnar [this message]
2007-07-08 20:17 ` Remy Bohmer
2007-07-09 14:46 ` Arjan van de Ven
2007-07-09 7:20 ` Matthieu CASTET
-- strict thread matches above, loose matches on Subject: below --
2007-08-20 12:12 Manfred Gruber
2007-08-20 12:59 ` Russell King - ARM Linux
2007-08-20 18:59 ` Remy Bohmer
2007-08-21 6:58 ` Manfred Gruber
2007-09-04 11:48 ` Manfred Gruber
2007-09-05 12:57 ` Remy Bohmer
2007-09-05 16:36 ` Manfred Gruber
2007-09-05 18:46 ` Remy Bohmer
2007-09-15 2:23 ` Steven Rostedt
2007-09-15 20:43 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070708095841.GA4601@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux@bohmer.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.