All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] PATCH: hwmon-fscher-individual-alarm-files-v3.patch
Date: Sun, 08 Jul 2007 17:33:57 +0000	[thread overview]
Message-ID: <20070708193357.2040251d@hyperion.delvare> (raw)
In-Reply-To: <468A3045.1010307@hhs.nl>

Hi Hans,

On Fri, 06 Jul 2007 17:17:41 +0200, Hans de Goede wrote:
> This is version 3 (non incremental) of the patch adding individual alarm and
> fault files to the fscher driver. This version automatically clears alarms
> when the condition for them is gone, and adds tempX_max sysfs atrributes.

Hmm, your patch actually does 4 different things:
* Add the individual alarm files.
* Add the tempX_max sysfs atrributes.
* Add (disabled) auto fan speed control trip points.
* Use arrays to reference register addresses.

That's a bit too much for a single patch. For easier review and faster
acceptance, you should split it into logical steps, each doing only one
thing. See what I did recently for the w83627ehf and lm85 drivers. 

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-07-08 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-03 11:17 [lm-sensors] Patch: hwmon-fscher-individual-alarm-files.patch Hans de Goede
2007-07-04 14:18 ` [lm-sensors] PATCH: hwmon-fscher-individual-alarm-files-v2.patch Hans de Goede
2007-07-04 14:44 ` Hans de Goede
2007-07-08 17:33 ` Jean Delvare [this message]
2007-07-08 19:18 ` [lm-sensors] PATCH: hwmon-fscher-individual-alarm-files-v3.patch Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2007-07-06 15:17 Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070708193357.2040251d@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.