All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] $(TARGET_CONFIGURE_OPTS) $(MAKE) vs $(MAKE)	$(TARGET_CONFIGURE_OPTS)
Date: Mon, 9 Jul 2007 10:25:50 +0200	[thread overview]
Message-ID: <20070709082550.GA19774@aon.at> (raw)
In-Reply-To: <05fb01c7c0e9$275c45a0$dcc4af0a@atmel.com>

On Sun, Jul 08, 2007 at 12:49:20AM +0200, Ulf Samuelsson wrote:
>> On Sat, Jul 07, 2007 at 09:37:05PM +0200, Ulf Samuelsson wrote:
>>>l?r 2007-07-07 klockan 19:29 +0200 skrev Bernhard Fischer:
>>>> On Sat, Jul 07, 2007 at 06:06:23PM +0200, Ulf Samuelsson wrote:
>>>> >> >I think someone got it wrong in the "package/mtd/mtd.mk" which says
>>>> >> >
>>>> >> >    $(TARGET_CONFIGURE_OPTS) $(MAKE) ...    - build using gcc
>>>> >> >    
>>>> >> >which should be:
>>>> >> >
>>>> >> >     $(MAKE) $(TARGET_CONFIGURE_OPTS) ...    - build using arm-linux-uclibc-gcc
>>>> >> 
>>>> >> yes, the latter is correct. Steven, please repair or elaborate.
>>>> >> 
>>>> >
>>>> >Here are a set of patches to change the position of
>>>> >TARGET_CONFIGURE_OPTS.
>>>> >Please review and apply if you agree.
>>>> >
>>>> >
>>>
>
>Stephen, can you pls review the mtd part of this patch ASAP,
>since this breaks the build for ARM (and possibly all non-x86).
>Pls commit (or ack my commit) if OK.

I've applied this now and will fix the other breakage due to not passing
CFLAGS any longer, thus building with package-imposed incorrect flags.

  reply	other threads:[~2007-07-09  8:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-06 12:35 [Buildroot] What is the proper procedure to commit a patch? Ulf Samuelsson
2007-07-06 15:26 ` Bernhard Fischer
2007-07-06 15:36   ` Ulf Samuelsson
2007-07-07 10:12     ` Bernhard Fischer
2007-07-07 11:16       ` Ulf Samuelsson
2007-07-07 12:35         ` Bernhard Fischer
2007-07-07 13:46           ` Ulf Samuelsson
2007-07-06 15:55 ` Steven J. Hill
2007-07-06 21:10   ` Ulf Samuelsson
2007-07-07 10:06   ` [Buildroot] $(TARGET_CONFIGURE_OPTS) $(MAKE) vs $(MAKE) $(TARGET_CONFIGURE_OPTS) Ulf Samuelsson
2007-07-07 13:01     ` Bernhard Fischer
2007-07-07 16:06       ` Ulf Samuelsson
2007-07-07 17:29         ` Bernhard Fischer
2007-07-07 19:37           ` Ulf Samuelsson
2007-07-07 21:16             ` Bernhard Fischer
2007-07-07 22:49               ` Ulf Samuelsson
2007-07-09  8:25                 ` Bernhard Fischer [this message]
2007-07-09  9:21                   ` Bernhard Fischer
2007-07-09 12:20                     ` Steven J. Hill
2007-07-09 13:41                       ` Julien Letessier
2007-07-09 13:08                         ` Ulf Samuelsson
2007-07-09 16:33                         ` Bernhard Fischer
2007-07-10 11:51                           ` Julien Letessier
2007-07-10 18:24                             ` Bernhard Fischer
2007-07-07 10:21 ` [Buildroot] What is the proper procedure to commit a patch? Bernhard Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070709082550.GA19774@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.