From: Matt Mackall <mpm@selenic.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Some love to default profiler
Date: Tue, 10 Jul 2007 07:43:44 -0500 [thread overview]
Message-ID: <20070710124343.GS11166@waste.org> (raw)
In-Reply-To: <20070704213420.GA5864@martell.zuzino.mipt.ru>
On Thu, Jul 05, 2007 at 01:34:20AM +0400, Alexey Dobriyan wrote:
> 1) Drop __KERNEL__ out of profile.h. It contains only internal kernel stuff and
> not in exported headers list
> 2) Put profile.c under CONFIG_PROFILING. You enabled profiling in config, you
> will get it. Removes conditional branch from schedule(). Code savings on my
> usual config:
>
> text data bss dec hex filename
> 2921871 179895 180224 3281990 321446 vmlinux before
> 2920141 179847 180224 3280212 320d54 vmlinux after
> --------------------------------------------------------------
> -1730 -48 -1778
>
> 3) Make timer_hook static (hi, Adrian!)
> 4) Convert do {} while (0) into static inline functions
> 5) minor misc stuff
Something here suggests this should have been 5 patches.
Otherwise, looks good to me.
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2007-07-10 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 21:34 [PATCH] Some love to default profiler Alexey Dobriyan
2007-07-04 22:39 ` Andi Kleen
2007-07-04 23:50 ` Jesper Juhl
2007-07-05 10:16 ` Denis Vlasenko
2007-07-05 10:20 ` Robert P. J. Day
2007-07-06 21:18 ` Alexey Dobriyan
2007-07-08 18:51 ` Adrian Bunk
2007-07-08 18:53 ` Jesper Juhl
2007-07-10 12:43 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710124343.GS11166@waste.org \
--to=mpm@selenic.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.