From: Andrew Morton <akpm@linux-foundation.org>
To: cmm@us.ibm.com
Cc: Theodore Tso <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev
Date: Tue, 10 Jul 2007 16:30:15 -0700 [thread overview]
Message-ID: <20070710163015.ab40ed2a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1183275361.4010.119.camel@localhost.localdomain>
On Sun, 01 Jul 2007 03:36:01 -0400
Mingming Cao <cmm@us.ibm.com> wrote:
> Turn on extents feature by default in ext4 filesystem. User could use
> -o noextents to turn it off.
>
Oh, there you go.
>
> Index: linux-2.6.22-rc4/fs/ext4/super.c
> ===================================================================
> --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:22.000000000 -0700
> +++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-11 17:03:09.000000000 -0700
> @@ -1546,6 +1546,12 @@
>
> set_opt(sbi->s_mount_opt, RESERVATION);
>
> + /*
> + * turn on extents feature by default in ext4 filesystem
> + * User -o noextents to turn it off
> + */
> + set_opt (sbi->s_mount_opt, EXTENTS);
> +
Broken coding style.
Please feed all the ext4 patches through scripts/checkpatch.pl (preferably
version 0.07 - see Andy's patch on lkml) and then consider addressing the
(quite large) number of mistakes which are detected.
next prev parent reply other threads:[~2007-07-10 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 7:36 [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev Mingming Cao
2007-07-10 23:30 ` Andrew Morton [this message]
2007-07-10 21:35 ` Mingming Cao
2007-07-11 3:35 ` Dave Jones
2007-07-11 3:15 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710163015.ab40ed2a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.