From: Thiemo Seufer <ths@networkno.de>
To: pwatkins@sicortex.com
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, From:
Subject: Re: [PATCH] [MIPS] Fix resume for 64K page size
Date: Tue, 10 Jul 2007 18:34:54 +0100 [thread overview]
Message-ID: <20070710173454.GA30521@networkno.de> (raw)
In-Reply-To: <11840880513393-git-send-email-pwatkins@sicortex.com>
pwatkins@sicortex.com wrote:
> This fixes a bug when running 64K page size on r4k machines.
>
>
> Signed-off-by: Peter Watkins <pwatkins@sicortex.com>
> ---
> arch/mips/kernel/r4k_switch.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/kernel/r4k_switch.S b/arch/mips/kernel/r4k_switch.S
> index 0672959..65f0f91 100644
> --- a/arch/mips/kernel/r4k_switch.S
> +++ b/arch/mips/kernel/r4k_switch.S
> @@ -85,7 +85,7 @@ #endif
> move $28, a2
> cpu_restore_nonscratch a1
>
> -#if (_THREAD_SIZE - 32) < 0x10000
> +#if (_THREAD_SIZE) < 0x10000
> PTR_ADDIU t0, $28, _THREAD_SIZE - 32
> #else
> PTR_LI t0, _THREAD_SIZE - 32
This doesn't look right. I think it should be
#if (_THREAD_SIZE - 32) < 0x8000
in order to avoid an overflow of the immediate.
Thiemo
WARNING: multiple messages have this Message-ID (diff)
From: Thiemo Seufer <ths@networkno.de>
To: pwatkins@sicortex.com
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] [MIPS] Fix resume for 64K page size
Date: Tue, 10 Jul 2007 18:34:54 +0100 [thread overview]
Message-ID: <20070710173454.GA30521@networkno.de> (raw)
Message-ID: <20070710173454.qKy8p8Jk5EqZg1LxBNsE0oDzKSF_WByPxGKIlNOrJNc@z> (raw)
In-Reply-To: <11840880513393-git-send-email-pwatkins@sicortex.com>
pwatkins@sicortex.com wrote:
> This fixes a bug when running 64K page size on r4k machines.
>
>
> Signed-off-by: Peter Watkins <pwatkins@sicortex.com>
> ---
> arch/mips/kernel/r4k_switch.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/kernel/r4k_switch.S b/arch/mips/kernel/r4k_switch.S
> index 0672959..65f0f91 100644
> --- a/arch/mips/kernel/r4k_switch.S
> +++ b/arch/mips/kernel/r4k_switch.S
> @@ -85,7 +85,7 @@ #endif
> move $28, a2
> cpu_restore_nonscratch a1
>
> -#if (_THREAD_SIZE - 32) < 0x10000
> +#if (_THREAD_SIZE) < 0x10000
> PTR_ADDIU t0, $28, _THREAD_SIZE - 32
> #else
> PTR_LI t0, _THREAD_SIZE - 32
This doesn't look right. I think it should be
#if (_THREAD_SIZE - 32) < 0x8000
in order to avoid an overflow of the immediate.
Thiemo
next prev parent reply other threads:[~2007-07-10 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 17:20 [PATCH] [MIPS] Fix resume for 64K page size pwatkins
2007-07-10 17:20 ` pwatkins
2007-07-10 17:15 ` Ralf Baechle
2007-07-10 17:15 ` Ralf Baechle
2007-07-10 17:34 ` Thiemo Seufer [this message]
2007-07-10 17:34 ` Thiemo Seufer
2007-07-11 7:36 ` Ralf Baechle
2007-07-11 7:36 ` Ralf Baechle
2007-07-10 17:36 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710173454.GA30521@networkno.de \
--to=ths@networkno.de \
--cc=linux-mips@linux-mips.org \
--cc=pwatkins@sicortex.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.