From: Al Viro <viro@ftp.linux.org.uk>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/5] revoke: core code
Date: Wed, 11 Jul 2007 11:18:03 +0100 [thread overview]
Message-ID: <20070711101803.GX21668@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0707111251280.12522@sbz-30.cs.Helsinki.FI>
On Wed, Jul 11, 2007 at 01:01:07PM +0300, Pekka J Enberg wrote:
> On Wed, 11 Jul 2007, Al Viro wrote:
> > BTW, read() or write() in progress might get rather unhappy if your
> > live replacement of ->f_mapping races with them...
>
> For writes, we (1) never start any new operations after we've cleaned up
> the file descriptor tables so (2) after we're done with do_fsync() we
> never touch ->f_mapping again.
Er, no. do_fsync() won't hit the sys_write() that is yet to enter
->write(). And you can't get rid of new callers _anyway_ (see
previous mail).
prev parent reply other threads:[~2007-07-11 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 9:01 [RFC/PATCH 2/5] revoke: core code Pekka J Enberg
2007-07-11 9:37 ` Al Viro
2007-07-11 9:42 ` Al Viro
2007-07-11 9:50 ` Pekka J Enberg
2007-07-11 10:09 ` Al Viro
2007-07-11 10:54 ` Pekka J Enberg
2007-07-11 10:01 ` Pekka J Enberg
2007-07-11 10:18 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711101803.GX21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.