From mboxrd@z Thu Jan  1 00:00:00 1970
From: rmccabe@sourceware.org <rmccabe@sourceware.org>
Date: 12 Jul 2007 02:42:43 -0000
Subject: [Cluster-devel] conga/luci homebase/index_html cluster/fence_d ...
Message-ID: <20070712024243.17696.qmail@sourceware.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

CVSROOT:	/cvs/cluster
Module name:	conga
Changes by:	rmccabe at sourceware.org	2007-07-12 02:42:42

Modified files:
	luci/homebase  : index_html 
	luci/cluster   : fence_device.js form-macros index_html 
	                 validate_config_qdisk.js validate_fence.js 

Log message:
	More fixes for MSIE

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/homebase/index_html.diff?cvsroot=cluster&r1=1.22&r2=1.23
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/fence_device.js.diff?cvsroot=cluster&r1=1.12&r2=1.13
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/form-macros.diff?cvsroot=cluster&r1=1.201&r2=1.202
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/index_html.diff?cvsroot=cluster&r1=1.35&r2=1.36
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_config_qdisk.js.diff?cvsroot=cluster&r1=1.6&r2=1.7
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&r1=1.8&r2=1.9

--- conga/luci/homebase/index_html	2007/06/25 16:03:38	1.22
+++ conga/luci/homebase/index_html	2007/07/12 02:42:42	1.23
@@ -119,7 +119,7 @@
 
 		<div class="retmsgs" id="retmsgsdiv" tal:condition="python:(ret and 'messages' in ret and len(ret['messages']))">
 			<div class="hbclosebox">
-				<a href="javascript:hide_element('retmsgsdiv');"><img src="x.png" class="closeBox" title="dismiss"></a>
+				<img onclick="hide_element('retmsgsdiv')" src="x.png" class="closeBox" title="dismiss" />
 			</div>
 			<p class="retmsgs">Status messages:</p>
 			<ul class="statusmsg">
@@ -131,7 +131,7 @@
 
 		<div id="errmsgsdiv" class="errmsgs" tal:condition="python:(ret and 'errors' in ret and len(ret['errors']))">
 			<div class="hbclosebox">
-				<a class="hbclosebox" href="javascript:hide_element('errmsgsdiv');"><img src="x.png" class="closeBox" title="dismiss"></a>
+				<img onclick="hide_element('errmsgsdiv')" src="x.png" class="closeBox" title="dismiss">
 			</div>
 			<p class="errmsgs">The following errors occurred:</p>
 			<ul class="statusmsg">
--- conga/luci/cluster/fence_device.js	2007/07/11 22:47:07	1.12
+++ conga/luci/cluster/fence_device.js	2007/07/12 02:42:42	1.13
@@ -33,8 +33,7 @@
 			} else if (	ielem[i].type == 'button' &&
 						ielem[i].name == 'remove_fence')
 			{
-				ielem[i].setAttribute('onclick',
-					'del_fence_instance(\'' + cloned_iform.id + '\')');
+				ielem[i].onclick = new Function('del_fence_instance(\'' + cloned_iform.id + '\')');
 			}
 		}
 
@@ -126,8 +125,7 @@
 			} else if (	ielem[i].type == 'button'
 						&& ielem[i].name == 'remove_fence')
 			{
-				ielem[i].setAttribute('onclick',
-					'del_fence_instance(\'' + cloned_iform.id + '\')');
+				ielem[i].onclick = new Function('del_fence_instance(\'' + cloned_iform.id + '\')');
 			}
 		}
 		idiv.appendChild(form_elem);
@@ -142,14 +140,14 @@
 	var remove_button = document.createElement('input');
 	remove_button.setAttribute('type', 'button');
 	remove_button.setAttribute('value', 'Remove this device');
-	remove_button.setAttribute('onclick', "del_fence('" + container_element.id + "');");
+	remove_button.onclick = new Function("del_fence('" + container_element.id + "');");
 
 	if (sharable) {
 		var add_instance_button = document.createElement('input');
 		add_instance_button.setAttribute('type', 'button');
 		add_instance_button.setAttribute('name', 'add_fence_inst');
 		add_instance_button.setAttribute('value', 'Add an instance');
-		add_instance_button.setAttribute('onclick', "add_fence_instance('" + container_element.id + "','" + fence_type + "');");
+		add_instance_button.onclick = new Function("add_fence_instance('" + container_element.id + "','" + fence_type + "');");
 		add_instance_button.className = 'pad_left';
 	}
 
--- conga/luci/cluster/form-macros	2007/07/11 22:47:07	1.201
+++ conga/luci/cluster/form-macros	2007/07/12 02:42:42	1.202
@@ -1918,10 +1918,10 @@
 			<tr>
 				<td>IP Address</td>
 				<td>
-					<input name="hostname" type="text"
+					<input name="ipaddr" type="text"
 						tal:attributes="
 							disabled cur_fencedev/isShared | nothing;
-							value cur_fencedev/hostname | nothing" />
+							value cur_fencedev/ipaddr | nothing" />
 				</td>
 			</tr>
 			<tr>
--- conga/luci/cluster/index_html	2007/06/27 08:14:12	1.35
+++ conga/luci/cluster/index_html	2007/07/12 02:42:42	1.36
@@ -203,7 +203,7 @@
 		<tal:block tal:define="ret python: request.SESSION.get('checkRet')">
 		<div class="retmsgs" id="retmsgsdiv" tal:condition="python:(ret and 'messages' in ret and len(ret['messages']))">
 			<div class="hbclosebox">
-				<a href="javascript:hide_element('retmsgsdiv')"><img src="/luci/homebase/x.png" class="closeBox" title="dismiss"></a>
+				<img onclick="hide_element('retmsgsdiv')" src="/luci/homebase/x.png" class="closeBox" title="dismiss" />
 			</div>
 			<p class="retmsgs">Status messages:</p>
 			<ul class="statusmsg">
@@ -215,7 +215,7 @@
 
 		<div id="errmsgsdiv" class="errmsgs" tal:condition="python:(ret and 'errors' in ret and len(ret['errors']))">
 			<div class="hbclosebox">
-				<a class="hbclosebox" href="javascript:hide_element('errmsgsdiv')"><img src="/luci/homebase/x.png" class="closeBox" title="dismiss"></a>
+				<img onclick="hide_element('errmsgsdiv')" src="/luci/homebase/x.png" class="closeBox" title="dismiss" />
 			</div>
 			<p class="errmsgs">The following errors occurred:</p>
 			<ul class="statusmsg">
--- conga/luci/cluster/validate_config_qdisk.js	2007/02/16 05:26:18	1.6
+++ conga/luci/cluster/validate_config_qdisk.js	2007/07/12 02:42:42	1.7
@@ -281,7 +281,7 @@
 	del_img.setAttribute('id', hstr + ':hdel');
 	del_img.setAttribute('src', '/luci/delete-row.png');
 	del_img.setAttribute('title', 'delete this row');
-	del_img.setAttribute('onClick', 'delete_qdisk_heur(this, document.quorum_partition)');
+	del_img.onclick = new Function('delete_qdisk_heur(this, document.quorum_partition)');
 	del_td.appendChild(del_img);
 
 	var tr = document.createElement('tr');
--- conga/luci/cluster/validate_fence.js	2007/07/11 22:47:07	1.8
+++ conga/luci/cluster/validate_fence.js	2007/07/12 02:42:42	1.9
@@ -258,8 +258,7 @@
 		for (var j = 0 ; j < select_elem.length ; j++) {
 			temp += '<input type="text" name="' + escapeXML(select_elem[j].name) + '" value="' + escapeXML(select_elem[j].options[select_elem[j].options.selectedIndex].value) + '" />';
 		}
-
-		form_xml += '<form id="' + escapeXML(form[i].getAttribute('name')) + '">' + temp + '</form>';
+		form_xml += '<form id="' + escapeXML(form[i].attributes['name'].value) + '">' + temp + '</form>';
 	}
 
 	master_form.fence_xml.value = '<formlist>' + form_xml + '</formlist>';