From: Andi Kleen <ak@suse.de>
To: linux-scsi@vger.kernel.org
Cc: James.Bottomley@steeleye.com
Subject: [PATCH] Mark initio.c driver as x86-32 only
Date: Thu, 12 Jul 2007 12:52:17 +0200 [thread overview]
Message-ID: <200707121252.17201.ak@suse.de> (raw)
initio.h contains this structure that is passed to the hardware:
typedef struct Scsi_Ctrl_Blk {
struct Scsi_Ctrl_Blk *SCB_NxtScb;
UBYTE SCB_Status; /*4 */
UBYTE SCB_NxtStat; /*5 */
UBYTE SCB_Mode; /*6 */
UBYTE SCB_Msgin; /*7 SCB_Res0 */
...
Which is obviously not 64bit safe. It also doesn't seem to dma map this
structure at all.
Mark the driver as X86_32 only in Kconfig.
Signed-off-by: Andi Kleen <ak@suse.de>
diff -u linux-2.6.22-dma/drivers/scsi/Kconfig-o linux-2.6.22-dma/drivers/scsi/Kconfig
--- linux-2.6.22-dma/drivers/scsi/Kconfig-o 2007-07-11 14:24:21.000000000 +0200
+++ linux-2.6.22-dma/drivers/scsi/Kconfig 2007-07-12 12:49:19.000000000 +0200
@@ -845,7 +845,8 @@
config SCSI_INITIO
tristate "Initio 9100U(W) support"
- depends on PCI && SCSI
+ # driver not 64bit safe and doesn't use pci dma API consistently
+ depends on PCI && SCSI && X86_32
help
This is support for the Initio 91XXU(W) SCSI host adapter. Please
read the SCSI-HOWTO, available from
reply other threads:[~2007-07-12 10:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707121252.17201.ak@suse.de \
--to=ak@suse.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.