All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Anderson <andmike@us.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: johnpol@2ka.mipt.ru, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com,
	akpm@linux-foundation.org, agk@redhat.com
Subject: Re: [2.6.23 PATCH 13/18] dm: netlink
Date: Thu, 12 Jul 2007 06:42:43 -0700	[thread overview]
Message-ID: <20070712134242.GA1671@us.ibm.com> (raw)
In-Reply-To: <20070712.032727.07453420.davem@davemloft.net>

David Miller <davem@davemloft.net> wrote:
> From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> Date: Thu, 12 Jul 2007 12:10:29 +0400
> 
> > On Wed, Jul 11, 2007 at 04:37:36PM -0700, Mike Anderson (andmike@us.ibm.com) wrote:
> > > > > --- linux.orig/include/linux/netlink.h	2007-07-11 21:37:31.000000000 +0100
> > > > > +++ linux/include/linux/netlink.h	2007-07-11 21:37:50.000000000 +0100
> > > > > @@ -21,7 +21,7 @@
> > > > >  #define NETLINK_DNRTMSG		14	/* DECnet routing messages */
> > > > >  #define NETLINK_KOBJECT_UEVENT	15	/* Kernel messages to userspace */
> > > > >  #define NETLINK_GENERIC		16
> > > > > -/* leave room for NETLINK_DM (DM Events) */
> > > > > +#define NETLINK_DM		17	/* Device Mapper */
> > > > >  #define NETLINK_SCSITRANSPORT	18	/* SCSI Transports */
> > > > >  #define NETLINK_ECRYPTFS	19
> > > > 
> > > > Have the net guys checked this?  
> > > 
> > > No. The support is a derivative of the netlink support in
> > > scsi_transport_iscsi.c.
> > 
> > I'm not sure about all net guys, but the first question rised after
> > reading this - why do you want special netlink family and do not want to
> > use interfaces created on top of - like connector and genetlink?
> 
> I agree, there is really no reason to not at least use
> genetlink.

ok, I will switch over to using genetlink.

-andmike
--
Michael Anderson
andmike@us.ibm.com

WARNING: multiple messages have this Message-ID (diff)
From: Mike Anderson <andmike@us.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: johnpol@2ka.mipt.ru, akpm@linux-foundation.org, agk@redhat.com,
	dm-devel@redhat.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [2.6.23 PATCH 13/18] dm: netlink
Date: Thu, 12 Jul 2007 06:42:43 -0700	[thread overview]
Message-ID: <20070712134242.GA1671@us.ibm.com> (raw)
In-Reply-To: <20070712.032727.07453420.davem@davemloft.net>

David Miller <davem@davemloft.net> wrote:
> From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> Date: Thu, 12 Jul 2007 12:10:29 +0400
> 
> > On Wed, Jul 11, 2007 at 04:37:36PM -0700, Mike Anderson (andmike@us.ibm.com) wrote:
> > > > > --- linux.orig/include/linux/netlink.h	2007-07-11 21:37:31.000000000 +0100
> > > > > +++ linux/include/linux/netlink.h	2007-07-11 21:37:50.000000000 +0100
> > > > > @@ -21,7 +21,7 @@
> > > > >  #define NETLINK_DNRTMSG		14	/* DECnet routing messages */
> > > > >  #define NETLINK_KOBJECT_UEVENT	15	/* Kernel messages to userspace */
> > > > >  #define NETLINK_GENERIC		16
> > > > > -/* leave room for NETLINK_DM (DM Events) */
> > > > > +#define NETLINK_DM		17	/* Device Mapper */
> > > > >  #define NETLINK_SCSITRANSPORT	18	/* SCSI Transports */
> > > > >  #define NETLINK_ECRYPTFS	19
> > > > 
> > > > Have the net guys checked this?  
> > > 
> > > No. The support is a derivative of the netlink support in
> > > scsi_transport_iscsi.c.
> > 
> > I'm not sure about all net guys, but the first question rised after
> > reading this - why do you want special netlink family and do not want to
> > use interfaces created on top of - like connector and genetlink?
> 
> I agree, there is really no reason to not at least use
> genetlink.

ok, I will switch over to using genetlink.

-andmike
--
Michael Anderson
andmike@us.ibm.com

  reply	other threads:[~2007-07-12 13:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11 21:01 [2.6.23 PATCH 13/18] dm: netlink Alasdair G Kergon
2007-07-11 21:01 ` Alasdair G Kergon
2007-07-11 21:27 ` Andrew Morton
2007-07-11 23:37   ` Mike Anderson
2007-07-11 23:37     ` Mike Anderson
2007-07-12  8:10     ` Evgeniy Polyakov
2007-07-12 10:27       ` David Miller
2007-07-12 13:42         ` Mike Anderson [this message]
2007-07-12 13:42           ` Mike Anderson
2007-07-12 23:19   ` Matt Mackall
2007-07-12 23:31     ` Andrew Morton
2007-07-12 23:31       ` Andrew Morton
2007-07-13  2:00       ` [dm-devel] " Mike Anderson
2007-07-13 20:12         ` Valdis.Kletnieks
2007-07-13 20:12           ` [dm-devel] " Valdis.Kletnieks
2007-07-13  7:03       ` Evgeniy Polyakov
2007-07-13  7:16         ` Kay Sievers
2007-07-12 23:45     ` Mike Anderson
2007-07-12 23:45       ` Mike Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070712134242.GA1671@us.ibm.com \
    --to=andmike@us.ibm.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dm-devel@redhat.com \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.