From: "J. Bruce Fields" <bfields@fieldses.org>
To: Greg Banks <gnb@sgi.com>
Cc: Neil Brown <neilb@suse.de>, nfs@lists.sourceforge.net
Subject: Re: [PATCH] nfsd: fix possible read-ahead cache and export table corruption
Date: Fri, 13 Jul 2007 13:46:25 -0400 [thread overview]
Message-ID: <20070713174625.GF12582@fieldses.org> (raw)
In-Reply-To: <20070713041019.GB20430@sgi.com>
On Fri, Jul 13, 2007 at 02:10:19PM +1000, Greg Banks wrote:
> My bad. The code I added really only works properly if the number
> of nfsd threads at startup is a multiple of 8, so that cache_size
> is a multiple of 16 and the shift doesn't lose any nonzero bits.
> As we use 128 threads in our product, I'd never noticed the bug :-(
It seems likely the distros all default to powers or 2, so that may make
it a little less likely to explain other bug reports I've seen. Oh
well. I'm not sure why I had this one test machine set to start 50
threads.
> There's a couple of other problems with that code, for which I'll send
> patches shortly. But I think the raparams cache needs a more thorough
> renovation than that. I have a mostly-working patch which rips it out
> entirely and replaces it with a cache of open struct files, an idea
> of Neil's. This approach fixes a whole bunch of separate problems
> at once, and will be really useful...
OK! What are the other problems you were thinking of?
--b.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-07-13 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 2:44 [PATCH] nfsd: fix possible read-ahead cache and export table corruption J. Bruce Fields
2007-07-13 4:10 ` Greg Banks
2007-07-13 17:46 ` J. Bruce Fields [this message]
2007-07-24 14:40 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070713174625.GF12582@fieldses.org \
--to=bfields@fieldses.org \
--cc=gnb@sgi.com \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.