All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Antoine Martin <antoine@nagafix.co.uk>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] ARCH=um SUBARCH=i386 breakage?
Date: Fri, 13 Jul 2007 14:44:41 -0400	[thread overview]
Message-ID: <20070713184441.GB9472@c2.user-mode-linux.org> (raw)
In-Reply-To: <4697B944.6030203@nagafix.co.uk>

On Fri, Jul 13, 2007 at 06:41:24PM +0100, Antoine Martin wrote:
> >Could you check this there by seeing if something like this builds
> >(with user.h removed):
> >
> >#include <asm/elf.h>
> >
> >int main(void){
> >	printf("%d %d\n", sizeof(elf_fpregset_t), sizeof(elf_fpxregset_t));
> >  
> My kernel headers are also missing elf.h, so this doesn't work either...

elf.h is supposedly exported in 2.6.22, although I guess someone took the
comment seriously:

	# These probably shouldn't be exported
	unifdef-y += shmparam.h
	unifdef-y += elf.h
	unifdef-y += page.h

So, I have no idea how userspace is supposed to figure out how big a
buffer to pass to PTRACE_GETFPREGS and PTRACE_GETFPXREGS.  I think the
headers are broken here.

> It is included in page.h:
> 
>  CC      arch/um/sys-i386/user-offsets.s
> In file included from /usr/include/asm/user.h:5,
>                 from arch/um/sys-i386/user-offsets.c:7:
> /usr/include/asm/page.h:4:25: error: linux/const.h: No such file or 
> directory

This is just broken, then.  The headers should at least have no
dangling includes.

> I get the same error as above because user.h includes  asm/page.h

Hummm, I guess the header tidying people need to fix a bunch of
things.  I'll make whatever changes needed in UML to not use illicit
headers, but I do need complete interface definitions, as with the FP
stuff.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2007-07-13 18:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13 11:06 [uml-devel] ARCH=um SUBARCH=i386 breakage? Antoine Martin
2007-07-13 12:03 ` Antoine Martin
2007-07-13 15:57   ` Jeff Dike
2007-07-13 17:41     ` Antoine Martin
2007-07-13 18:44       ` Jeff Dike [this message]
2007-07-14  9:23         ` Antoine Martin
2007-07-14 12:00           ` Jeff Dike
2007-07-15 17:08             ` Antoine Martin
2007-07-19  1:13               ` Daniel Gryniewicz
2007-07-19  1:25                 ` Jeff Dike
2007-07-19 19:54                 ` Antoine Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070713184441.GB9472@c2.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=antoine@nagafix.co.uk \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.