From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1I9Td4-00066a-Ll for mharc-grub-devel@gnu.org; Fri, 13 Jul 2007 18:28:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I9Td3-00064l-00 for grub-devel@gnu.org; Fri, 13 Jul 2007 18:28:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I9Td1-000638-Cx for grub-devel@gnu.org; Fri, 13 Jul 2007 18:28:48 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I9Td1-00062z-14 for grub-devel@gnu.org; Fri, 13 Jul 2007 18:28:47 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I9Td0-0001AG-ME for grub-devel@gnu.org; Fri, 13 Jul 2007 18:28:46 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1I9Tcz-0000vS-8Q for grub-devel@gnu.org; Sat, 14 Jul 2007 00:28:45 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1I9TfC-0005Y9-Bd for grub-devel@gnu.org; Sat, 14 Jul 2007 00:31:02 +0200 Date: Sat, 14 Jul 2007 00:31:02 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070713223102.GC20231@aragorn> References: <20070709150550.GA13390@aragorn> <1184099203.9495.70.camel@basalt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1184099203.9495.70.camel@basalt> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: GRUB_IEEE1275_FLAG_NO_PARTITION_0 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2007 22:28:49 -0000 On Tue, Jul 10, 2007 at 03:26:43PM -0500, Hollis Blanchard wrote: > On Mon, 2007-07-09 at 17:05 +0200, Robert Millan wrote: > > What's the point of GRUB_IEEE1275_FLAG_NO_PARTITION_0 ? We have code that > > checks this flag, but nobody initialises it: > > > > disk/ieee1275/ofdisk.c: if (! grub_ieee1275_test_flag (GRUB_IEEE1275_FLAG_NO_PARTITION_0)) > > include/grub/ieee1275/ieee1275.h: GRUB_IEEE1275_FLAG_NO_PARTITION_0, > > In IEEE1275, partition 0 (as in "disk:0") means "the whole disk". > However, CodeGen-based firmware (that means Genesi) have a bug where > partition 0 is actually disk partition 1. In that case, to access the > whole disk, GRUB must open "disk" instead of "disk:0". Yes, but don't we already have GRUB_IEEE1275_FLAG_0_BASED_PARTITIONS for that ? > I have no idea how the initialization got lost; it should be initialized > in the same place that the other flags are. Checking cvs history may be > in order. It was this commit: 2005-04-30 Hollis Blanchard * boot/powerpc/ieee1275/cmain.c: [...] [...]. Set GRUB_IEEE1275_FLAG_REAL_MODE and GRUB_IEEE1275_FLAG_0_BASED_PARTITIONS. doesn't mention it, but it also added GRUB_IEEE1275_FLAG_NO_PARTITION_0. Should we merge these flags? They appear to mean the same to me. -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.