All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul Moore" <paul.moore@hp.com>
To: selinux@tycho.nsa.gov, michal.k.k.piotrowski@gmail.com
Subject: [PATCH 0/2] Fix for the unlabeled NetLabel access check patch
Date: Fri, 13 Jul 2007 23:04:01 -0400	[thread overview]
Message-ID: <20070714030401.888612123@hp.com> (raw)

This patchset consists of two patches, both based against Linus' tree of about
an hour ago. the first is largely a resend of a previous patch which was
accepted into 2.6.23, the second is a fix for the first patch because it broke
stuff :/   More information about the breakage can be found in the link in the
patch description.

The first patch is the patch which converted NetLabel to make use of the netmsg
initial SID for MLS labeled packets so that the unlabeled initial SID could be
used for truly unlabeled packets.  Unfortunately, this turned out to cause
problems on systems with older policy.  The second patch in this series
addresses this problem by providing a runtime enable/disable status flag for
NetLabel which SELinux (and other LSMs for that matter) can use to decide if
they should perform NetLabel label enforcement.

I've given this patchset a quick test and everything behaves as I would expect,
that is to say the following happens:

 1. When the system is booted NetLabel is disabled (no NetLabel config present)
    - no NetLabel access checks for labeled or unlabeled packets
 2. Once NetLabel is configured (netlabelctl cipsov4 add ...) NetLabel is
    enabled
    - NetLabel access checks are performed for both labeled and unlabeled
      packets
 3. If all of the NetLabel labeled protocol configurations are removed
    (netlabelctl cipsov4 del ...) then NetLabel is disabled again
    - no NetLabel access checks for labeled or unlabeled packets

This should solve the problems seen in the early 2.6.23 git kernels.

Michal, if you're not sick of verifying things yet - could you test this
patchset on your configuration and verify that you do not see any regressions?

Thank you all for your patience, and sorry for all the confusion.

-- 
paul moore
linux security @ hp

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

             reply	other threads:[~2007-07-14  3:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-14  3:04 Paul Moore [this message]
2007-07-14  3:04 ` [PATCH 1/2] SELinux: use SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel Paul Moore
2007-07-14  3:04 ` [PATCH 2/2] NetLabel: enable dynamic activation/deactivation of NetLabel/SELinux enforcement Paul Moore
2007-07-14 14:09   ` James Morris
2007-07-14 14:21     ` Paul Moore
2007-07-14 15:26       ` James Morris
2007-07-14 15:47         ` Paul Moore
2007-07-14 15:50           ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070714030401.888612123@hp.com \
    --to=paul.moore@hp.com \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.