All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present
Date: Fri, 13 Jul 2007 21:00:50 -0700	[thread overview]
Message-ID: <20070714040050.GA11773@kroah.com> (raw)
In-Reply-To: <20070713182818.fd37372f.sfr@canb.auug.org.au>

On Fri, Jul 13, 2007 at 06:28:18PM +1000, Stephen Rothwell wrote:
> On Thu, 12 Jul 2007 23:34:14 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote:
> > > Greg KH <greg@kroah.com> writes:
> > > 
> > > > When using git-send-email.perl on a changeset that has:
> > > > 	Cc: <stable@kernel.org>
> > > > in the body of the description, and the Email::Valid perl module is
> > > > installed on the system, the email address will be deemed "invalid" for
> > > > some reason (Email::Valid isn't smart enough to handle this?) and
> > > > complain and not send the address the email.
> > > 
> > > That appears to be the case.
> > > 
> > >         bad foo
> > >         bad <foo@bar.baz>
> > >         ok  foo@bar.baz
> > >         ok  Foo <foo@bar.baz>
> 
> This would be a bug in Email::Valid as it complains that the second
> address fails the rfc822 check, however rfc822 says that the "display
> name" before the '<' is optional.

I agree, do you know how to get such a fix made?

thanks,

greg k-h

  reply	other threads:[~2007-07-14  4:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13  4:17 [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Greg KH
2007-07-13  5:47 ` Junio C Hamano
2007-07-13  6:34   ` Greg KH
2007-07-13  8:28     ` Stephen Rothwell
2007-07-14  4:00       ` Greg KH [this message]
2007-07-14 10:38         ` Stephen Rothwell
2007-08-09 12:28 ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070714040050.GA11773@kroah.com \
    --to=greg@kroah.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.