From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759290AbXGNQ0d (ORCPT ); Sat, 14 Jul 2007 12:26:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754991AbXGNQ00 (ORCPT ); Sat, 14 Jul 2007 12:26:26 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:42108 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754573AbXGNQ0Z (ORCPT ); Sat, 14 Jul 2007 12:26:25 -0400 Date: Sat, 14 Jul 2007 17:26:19 +0100 From: Christoph Hellwig To: Mathieu Desnoyers Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, prasanna@in.ibm.com, ananth@in.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net Subject: Re: [patch 5/8] Immediate Values - kprobe header fix Message-ID: <20070714162619.GC13831@infradead.org> Mail-Followup-To: Christoph Hellwig , Mathieu Desnoyers , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, prasanna@in.ibm.com, ananth@in.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net References: <20070714012439.285079881@polymtl.ca> <20070714012624.150971859@polymtl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070714012624.150971859@polymtl.ca> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 13, 2007 at 09:24:44PM -0400, Mathieu Desnoyers wrote: > Since the immediate values depend on the same int3 handler as kprobes implements > for i386, we have to get architecture specific defines available for the kprobes > trap handler (especially restore_interrupts()) wven when CONFIG_KPROBES is not > selected. > > That kind of ifdef around a whole header does not make sense in the first place > anyway. > > Signed-off-by: Mathieu Desnoyers > CC: prasanna@in.ibm.com > CC: ananth@in.ibm.com > CC: anil.s.keshavamurthy@intel.com > CC: davem@davemloft.net > --- > include/linux/kprobes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6-lttng/include/linux/kprobes.h > =================================================================== > --- linux-2.6-lttng.orig/include/linux/kprobes.h 2007-07-13 18:47:57.000000000 -0400 > +++ linux-2.6-lttng/include/linux/kprobes.h 2007-07-13 18:48:45.000000000 -0400 > @@ -36,9 +36,9 @@ > #include > #include > > -#ifdef CONFIG_KPROBES > #include but this one isn't available on architectures that don't have kprobes, so you can't include linux/kprobes.h in generic code without ifdef protection anymore. I'd say move the code to asm/kdebug.h if it's need by more than just kprobes.