From: Olaf Hering <olaf@aepfle.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove PAGE_SIZE from headers_install
Date: Sat, 14 Jul 2007 23:34:12 +0200 [thread overview]
Message-ID: <20070714213412.GA10196@aepfle.de> (raw)
In-Reply-To: <46993C59.1030902@zytor.com>
On Sat, Jul 14, H. Peter Anvin wrote:
> Olaf Hering wrote:
> > Declare PAGE_SIZE as getpagesize() for userspace.
> > PAGE_SIZE is used in resource.h and shm.h
>
> I would think it would be better to not define it at all. Several
> architectures already don't have PAGE_SIZE visible to userspace in any way.
i386 has it, so everyone uses it.
asm/user.h uses it for NBPG, which appears in gdb configure scripts.
Maybe it doesnt trigger there because the sysconf SC_* macros match.
other places where asm/page.h is used:
util-linux configure scripts, strace, xorg-11, and alot more.
Have to check if they really need it.
next prev parent reply other threads:[~2007-07-14 21:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 20:57 [PATCH] remove PAGE_SIZE from headers_install Olaf Hering
2007-07-14 21:04 ` Mike Frysinger
2007-07-15 6:27 ` Olaf Hering
2007-07-15 7:20 ` Mike Frysinger
2007-07-15 10:10 ` David Woodhouse
2007-08-04 10:04 ` Olaf Hering
2007-07-15 7:51 ` Olaf Hering
2007-07-14 21:12 ` H. Peter Anvin
2007-07-14 21:34 ` Olaf Hering [this message]
2007-07-14 22:59 ` Mike Frysinger
2007-07-15 8:01 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2007-07-14 21:40 Mikael Pettersson
2007-07-15 2:48 Albert Cahalan
2007-07-15 3:19 ` H. Peter Anvin
2007-07-15 3:43 ` David Miller
2007-07-15 4:49 ` Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714213412.GA10196@aepfle.de \
--to=olaf@aepfle.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.