From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242AbXGNXDS (ORCPT ); Sat, 14 Jul 2007 19:03:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755251AbXGNXDL (ORCPT ); Sat, 14 Jul 2007 19:03:11 -0400 Received: from tomts20-srv.bellnexxia.net ([209.226.175.74]:39448 "EHLO tomts20-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753102AbXGNXDK (ORCPT ); Sat, 14 Jul 2007 19:03:10 -0400 Date: Sat, 14 Jul 2007 18:57:58 -0400 From: Mathieu Desnoyers To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Cc: Christoph Hellwig Subject: Re: (drop : wrong email thread) [PATCH] Immediate Values - Architecture Independent Code - Fixes following HCH comments Message-ID: <20070714225758.GB18674@Krystal> References: <20070714012133.612727310@polymtl.ca> <20070714012411.845928928@polymtl.ca> <20070714225529.GA18674@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20070714225529.GA18674@Krystal> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 18:57:10 up 7 days, 13:02, 2 users, load average: 0.38, 0.28, 0.20 User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Sorry, this email is sent in the wrong thread. Please drop, I will resend in the right thread. * Mathieu Desnoyers (mathieu.desnoyers@polymtl.ca) wrote: > Immediate Values - Architecture Independent Code - Fixes following HCH comments > > Various coding style fixes following Christoph's comments > Put asm-generic/immediate.h content into linux/immediate.h. > Remove ifdef __KERNEL__ in .h never exported to user space. > Make immediate_mutex static. > > It applies after "Immediate Values - Architecture Independent Code". > > Signed-off-by: Mathieu Desnoyers > CC: Christoph Hellwig > --- > include/linux/immediate.h | 18 ++++++++++++++---- > kernel/immediate.c | 15 +++++++-------- > 2 files changed, 21 insertions(+), 12 deletions(-) > > Index: linux-2.6-lttng/include/linux/immediate.h > =================================================================== > --- linux-2.6-lttng.orig/include/linux/immediate.h 2007-07-14 18:13:58.000000000 -0400 > +++ linux-2.6-lttng/include/linux/immediate.h 2007-07-14 18:16:26.000000000 -0400 > @@ -10,12 +10,23 @@ > * See the file COPYING for more details. > */ > > -#ifdef __KERNEL__ > - > #ifdef CONFIG_IMMEDIATE > #include > #else > -#include > +/* > + * Generic immediate values: a simple, standard, memory load. > + */ > + > +struct module; > + > +#define immediate_read(var) _immediate_read(var) > +#define immediate_set(var, i) ((var)->value = (i)) > +#define _immediate_set(var, i) immediate_set(var, i) > +#define immediate_set_early(var, i) immediate_set(var, i) > +#define immediate_if(var) if (immediate_read(var)) > + > +static inline void module_immediate_setup(struct module *mod) { } > +static inline void immediate_update_early(void) { } > #endif > > /* > @@ -49,5 +60,4 @@ DEFINE_IMMEDIATE_TYPE(void*, immediate_v > */ > #define _immediate_if(var) if (_immediate_read(var)) > > -#endif /* __KERNEL__ */ > #endif > Index: linux-2.6-lttng/kernel/immediate.c > =================================================================== > --- linux-2.6-lttng.orig/kernel/immediate.c 2007-07-14 18:13:58.000000000 -0400 > +++ linux-2.6-lttng/kernel/immediate.c 2007-07-14 18:27:03.000000000 -0400 > @@ -27,13 +27,13 @@ extern const struct __immediate __stop__ > * modules_mutex nests inside immediate_mutex. immediate_mutex protects builtin > * immediates and module immediates. > */ > -DEFINE_MUTEX(immediate_mutex); > +static DEFINE_MUTEX(immediate_mutex); > > /* > * Sets a range of immediates to a enabled state : set the enable bit. > */ > -static void _immediate_update_range( > - const struct __immediate *begin, const struct __immediate *end) > +static inline void _immediate_update_range(const struct __immediate *begin, > + const struct __immediate *end) > { > const struct __immediate *iter; > int ret; > @@ -63,11 +63,10 @@ static void _immediate_update_range( > */ > void module_immediate_setup(struct module *mod) > { > - _immediate_update_range(mod->immediate, mod->immediate+mod->num_immediate); > + _immediate_update_range(mod->immediate, > + mod->immediate+mod->num_immediate); > } > -#endif > > -#ifdef CONFIG_MODULES > /* > * immediate mutex nests inside the modules mutex. > */ > @@ -103,8 +102,8 @@ EXPORT_SYMBOL_GPL(immediate_update); > * Update the immediate values to the state of the variables they refer to. It > * is done before SMP is active, at the very beginning of start_kernel(). > */ > -void __init immediate_update_early_range( > - const struct __immediate *begin, const struct __immediate *end) > +void __init immediate_update_early_range(const struct __immediate *begin, > + const struct __immediate *end) > { > const struct __immediate *iter; > > > -- > Mathieu Desnoyers > Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68