Re: [PATCH] fix ASSERT and ASSERT_ALWAYS

[David Chinner <dgc@sgi.com>]

On Sat, Jul 14, 2007 at 06:04:21PM +0200, Christoph Hellwig wrote:
>  - remove the != 0 inside the unlikely in ASSERT_ALWAYS because sparse now
>    complains about comparisms between pointers and 0
>  - add a standalone ASSERT implementation because defining it to
>    ASSERT_ALWAYS means the string is expanded before the #token passing
>    stringification.  This way we get the actual content of the
>    assertatio in the assfail message and don't overflow sparse's
>    strinification buffer leading to sparse error messages.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

OK.

Rather than replying to each patch, Christoph - I've taken the
whole set into my queue for 2.6.24. All the warnings and cleanups
look ok and should not be a problem, but I need to have a much
closer look at the bmbt_rec endian notation series before that
goes further.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group