All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Samuel Ortiz <samuel.ortiz@solidboot.com>,
	davem@davemloft.net, eric.y.miao@gmail.com, sam@ravnborg.org,
	netdev@vger.kernel.org, irda-users@lists.sourceforge.net,
	stable@kernel.org
Subject: Re: [PATCH] [IrDA] Fix IrDA build failure
Date: Mon, 16 Jul 2007 14:07:44 +0200	[thread overview]
Message-ID: <20070716120744.GD3653@stusta.de> (raw)
In-Reply-To: <20070716115624.GA4492@2ka.mipt.ru>

On Mon, Jul 16, 2007 at 03:56:26PM +0400, Evgeniy Polyakov wrote:
> Hi Samuel.
> 
> On Mon, Jul 16, 2007 at 02:17:15PM +0300, Samuel Ortiz (samuel.ortiz@solidboot.com) wrote:
> > This is due to the irda_init fix recently added, where we call __exit
> > routines from an __init one. It is a build failure that I didn't catch
> > because it doesn't show up when building IrDA as a module. My apologies
> > for that.
> 
> What about having all of them __devinit/__devexit?

That would be completely wrong.

> 	Evgeniy Polyakov

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-07-16 12:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-16 11:17 [PATCH] [IrDA] Fix IrDA build failure Samuel Ortiz
2007-07-16 11:56 ` Evgeniy Polyakov
2007-07-16 12:07   ` Adrian Bunk [this message]
2007-07-16 12:17     ` Evgeniy Polyakov
2007-07-16 13:05       ` Adrian Bunk
2007-07-16 15:16   ` Sam Ravnborg
2007-07-16 13:00 ` [irda-users] " Samuel Ortiz
2007-07-17  5:08   ` Adrian Bunk
     [not found] ` <20070716111715.GB22757-OPs8hQ7j6VREYlHNa9+yaNBPR1lH4CV8@public.gmane.org>
2007-07-18  9:17   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070716120744.GD3653@stusta.de \
    --to=bunk@stusta.de \
    --cc=davem@davemloft.net \
    --cc=eric.y.miao@gmail.com \
    --cc=irda-users@lists.sourceforge.net \
    --cc=johnpol@2ka.mipt.ru \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=samuel.ortiz@solidboot.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.