All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Dmitriy Zavin <dmitriyz@google.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andi Kleen <andi@firstfloor.org>, Ashok Raj <ashok.raj@intel.com>
Subject: [PATCH 0/10] CPU hotplug error handling fixes
Date: Mon, 16 Jul 2007 22:48:55 +0900	[thread overview]
Message-ID: <20070716134855.GA1858@APFDCB5C> (raw)

This series of patches fixes the error handling for cpu hotplug.
The problem is revealed by CPU hotplug/unplug test with fault-injection.

The patch 1-3 are sysfs or driver core related error handling fixes.
These are not directly related to cpu hotplug. But these are needed to
pass the stress test.

The patch 4 changes the behavior when one of the callbacks in notifier
chain returns NOTIFY_BAD with CPU_UP_PREPARE event. This change makes
cpu hotplug error handling simple.

The patch 5 simplifies the cpu hotplug event handling in topology.c
by the patch 4.

The patch 6-10 are error handling fixes in cpu hotplug event callbacks.
These fixes also depend on the change by the patch 4.

Here is the test script I have confirmed with these patches.
I guess we still have the similar bugs that I could not test due to no
hardware. So it may be worth someone trying this script.

----------[ cut here ]----------

#!/bin/bash

FAILTYPE=failslab
CPU=1
CPU_ONLINE=/sys/devices/system/cpu/cpu${CPU}/online

faulty_system()
{
        bash -c "echo 1 > /proc/self/make-it-fail && exec $*"
}

[ "$UID" == 0 ] || exit 1
[ -n "$FAILTYPE" -a -f /debug/$FAILTYPE/probability ] || exit 1
[ -f $CPU_ONLINE ] || exit 1

echo N > /debug/$FAILTYPE/ignore-gfp-wait
echo Y > /debug/$FAILTYPE/task-filter
echo 1 > /debug/$FAILTYPE/probability
echo -1 > /debug/$FAILTYPE/times

while true
do
	faulty_system "echo 0 > $CPU_ONLINE"
	faulty_system "echo 1 > $CPU_ONLINE"
done


             reply	other threads:[~2007-07-16 13:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-16 13:48 Akinobu Mita [this message]
2007-07-16 13:50 ` [PATCH 1/10] sysfs: fix kmem_cache_free(NULL) Akinobu Mita
2007-07-16 15:43   ` Greg KH
2007-07-16 16:53     ` Akinobu Mita
2007-07-17  7:04       ` Pekka J Enberg
2007-07-16 13:51 ` [PATCH 2/10] sysdev: add error check in sysdev_register() Akinobu Mita
2007-07-16 15:12   ` Cornelia Huck
2007-07-16 16:18     ` Akinobu Mita
2007-07-16 13:52 ` [PATCH 3/10] sysfs: fix error handling in create_files() Akinobu Mita
2007-07-16 15:29   ` Cornelia Huck
2007-07-16 16:28     ` Akinobu Mita
2007-07-16 16:29     ` Greg KH
2007-07-17 16:22       ` Akinobu Mita
2007-07-16 13:53 ` [PATCH 4/10] cpu: deliver CPU_UP_CANCELED only to NOTIFY_OKed callbacks with CPU_UP_PREPARE Akinobu Mita
2007-07-17  8:23   ` Gautham R Shenoy
2007-07-17 17:18     ` Akinobu Mita
2007-07-18  6:54       ` Gautham R Shenoy
2007-07-18 16:28         ` Akinobu Mita
2007-07-16 13:54 ` [PATCH 5/10] topology: remove topology_dev_map Akinobu Mita
2007-07-16 13:57 ` [PATCH 6/10] thermal_throttle: fix cpu hotplug error handling Akinobu Mita
2007-07-16 13:58 ` [PATCH 7/10] msr: " Akinobu Mita
2007-07-16 13:58 ` [PATCH 8/10] cpuid: " Akinobu Mita
2007-07-16 14:00 ` [PATCH 9/10] mce: " Akinobu Mita
2007-07-16 14:01 ` [PATCH 10/10] intel_cacheinfo: " Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070716134855.GA1858@APFDCB5C \
    --to=akinobu.mita@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=ashok.raj@intel.com \
    --cc=dmitriyz@google.com \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.