From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PATCH: Ensure RTL 8139 MMIO regions are 4k apart
Date: Mon, 16 Jul 2007 18:18:05 +0100 [thread overview]
Message-ID: <20070716171805.GI19538@redhat.com> (raw)
In-Reply-To: <200707161807.18786.paul@codesourcery.com>
On Mon, Jul 16, 2007 at 06:07:18PM +0100, Paul Brook wrote:
> > The hw/rtl8139.c code is passing 0x100 in as the size parameter for the
> > cpu_register_physical_memory call, despite the fact that the API contract
> > says size has to be a multiple of page size.
>
> Have you tried recent CVS? This should not be necessary.
I thought I had - but my checkout was synced to the 0.9.0 release :-( Re-tested
with latest HEAD and it works OK without needing this patch. Sorry for the
noise.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
prev parent reply other threads:[~2007-07-16 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 17:03 [Qemu-devel] PATCH: Ensure RTL 8139 MMIO regions are 4k apart Daniel P. Berrange
2007-07-16 17:07 ` Paul Brook
2007-07-16 17:18 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716171805.GI19538@redhat.com \
--to=berrange@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.