From: bdowning@lavos.net (Brian Downing)
To: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Do _not_ call unlink on a directory
Date: Mon, 16 Jul 2007 12:42:39 -0500 [thread overview]
Message-ID: <20070716174239.GG19073@lavos.net> (raw)
In-Reply-To: <11846075213759-git-send-email-sithglan@stud.uni-erlangen.de>
On Mon, Jul 16, 2007 at 07:38:41PM +0200, Thomas Glanzmann wrote:
> const char *slash = path;
> + struct stat st;
> memcpy(buf, path, len);
> buf[len] = 0;
> + if (!stat(buf, &st) && S_ISDIR(st.st_mode))
> + continue; /* ok */
You've got some whitespace damage here. Git's style is to use tabs.
-bcd
next prev parent reply other threads:[~2007-07-16 17:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 17:12 [PATCH] Do _not_ call unlink on a directory Thomas Glanzmann
2007-07-16 17:18 ` Matthieu Moy
2007-07-16 19:05 ` Scott Lamb
2007-07-16 19:56 ` Thomas Glanzmann
2007-07-16 20:00 ` Thomas Glanzmann
2007-07-16 20:21 ` Linus Torvalds
2007-07-16 20:25 ` Thomas Glanzmann
2007-07-16 20:34 ` Linus Torvalds
2007-07-16 20:39 ` Thomas Glanzmann
2007-07-16 21:23 ` Scott Lamb
2007-07-16 21:44 ` Linus Torvalds
2007-07-16 21:58 ` Scott Lamb
2007-07-16 22:03 ` Linus Torvalds
2007-07-16 20:29 ` Linus Torvalds
2007-07-16 17:38 ` Thomas Glanzmann
2007-07-16 17:41 ` Jan-Benedict Glaw
2007-07-16 17:42 ` Brian Downing [this message]
2007-07-16 17:55 ` Thomas Glanzmann
2007-07-16 19:58 ` Linus Torvalds
2007-07-16 21:06 ` Brian Downing
2007-07-16 21:19 ` Linus Torvalds
2007-07-17 8:58 ` David Kastrup
2007-07-17 7:30 ` Junio C Hamano
2007-07-17 8:28 ` Junio C Hamano
2007-07-17 10:15 ` Thomas Glanzmann
2007-07-17 18:34 ` Junio C Hamano
2007-07-17 20:27 ` Thomas Glanzmann
2007-07-18 7:24 ` Johannes Sixt
2007-07-18 8:50 ` Thomas Glanzmann
2007-07-17 19:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716174239.GG19073@lavos.net \
--to=bdowning@lavos.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sithglan@stud.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.