From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [third][PATCH 3/4][2.6 drivers/net/skfp/smt.c:]replace SIZE
Date: Mon, 16 Jul 2007 17:48:46 +0000 [thread overview]
Message-ID: <20070716174846.GN13826@parisc-linux.org> (raw)
In-Reply-To: <20070716141818.30653.70760.sendpatchset@shcherbakov.homelinux.net>
On Mon, Jul 16, 2007 at 05:33:10PM +0000, Cripps wrote:
> I just assumed that the original maintainer of the code had a good reason
> for writing the loop in the way he did. and cleaned up the piece that
> pertained to my project. The way it is now still compiles with no errors, so
> it must not be *entirely* broken (if at all).
> Thanks for the comments. If the piece of code in question can actually use
> some cleaning up, maybe you should get in contact with the maintainer and
> talk it out ... as I've learned from previous attempts though, that change
> is beyond the scope of this patch, and as such shouldn't be touched in this
> patch. :)
Absolutely right.
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
_______________________________________________
REMINDER: this mailing list moved to vger.kernel.org and current one will be discontinued soon.
To resubscribe, send email to majordomo@vger.kernel.org with
"subscribe kernel-janitors" in message body and follow instructions.
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2007-07-16 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 14:06 [KJ] [third][PATCH 3/4][2.6 drivers/net/skfp/smt.c:]replace SIZE acripps
2007-07-16 17:06 ` walter harms
2007-07-16 17:24 ` Nishanth Aravamudan
2007-07-16 17:25 ` Matthew Wilcox
2007-07-16 17:33 ` Cripps
2007-07-16 17:48 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716174846.GN13826@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.