From: Andi Kleen <ak@suse.de>
To: Nick Piggin <npiggin@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [rfc][patch 2/2] x86_64: FIFO ticket spinlocks
Date: Tue, 17 Jul 2007 16:25:42 +0200 [thread overview]
Message-ID: <200707171625.42235.ak@suse.de> (raw)
In-Reply-To: <20070716050134.GB19914@wotan.suse.de>
When you revamp everything I guess it would make the locks
easier to read to just put them into a .S file? They're
out of line anyways.
In general they look ok.
>
> static inline void __raw_spin_unlock(raw_spinlock_t *lock)
> {
> - asm volatile("movl $1,%0" :"=m" (lock->slock) :: "memory");
> + __asm__ __volatile__(
Minor nit: please don't use these underlined keywords. They just look
ugly and asm volatile works as well.
-Andi
next prev parent reply other threads:[~2007-07-17 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 4:59 [rfc][patch 1/2] spinlock: lockbreak cleanups Nick Piggin
2007-07-16 5:01 ` [rfc][patch 2/2] x86_64: FIFO ticket spinlocks Nick Piggin
2007-07-16 9:16 ` Alan Cox
2007-07-16 9:24 ` Nick Piggin
2007-07-16 9:26 ` Ingo Molnar
2007-07-16 9:45 ` Nick Piggin
2007-07-16 9:49 ` Ingo Molnar
2007-07-16 10:18 ` Nick Piggin
2007-07-17 14:25 ` Andi Kleen [this message]
2007-07-17 15:08 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707171625.42235.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.