From: Matthew Wilcox <matthew@wil.cx>
To: Ken Witherow <ken@krwtech.com>
Cc: linux-scsi@vger.kernel.org, jeffreyfreeman@syncleus.com,
Christoph Hellwig <hch@infradead.org>
Subject: Re: advansys cleanup
Date: Tue, 17 Jul 2007 10:37:54 -0600 [thread overview]
Message-ID: <20070717163754.GD14791@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707171103500.20043@death.krwtech.com>
On Tue, Jul 17, 2007 at 11:36:11AM -0400, Ken Witherow wrote:
> Instead, I pulled the raw advansys.c from the tree provided and dropped
> that in place.
Hm, sorry about that. I suspect that advansys.c has changed since
2.6.22.
> CC drivers/scsi/advansys.o
> drivers/scsi/advansys.c:795:2: warning: #warning this driver is still not
> properly converted to the DMA API
Yeah, I'm not planning on getting rid of that warning. Yet, anyway.
> MODPOST vmlinux
> WARNING: drivers/built-in.o(.text+0x99045): Section mismatch: reference to
> .init.text: (between 'advansys_board_found' and 'advansys_pci_probe')
Oops. Probably simple to fix, I'll look into that.
>
> I've attached my regular dmesg as well as my dmesg with the failure of the
> updated advansys driver.
The important bit is this one:
-ACPI: PCI Interrupt 0000:00:09.0[A] -> GSI 17 (level, low) -> IRQ 16
-scsi0 : AdvanSys SCSI 3.3K: PCI Ultra: IO 0x1800-0x180F, IRQ 0x10
+scsi0 : AdvanSys SCSI 3.3K: PCI Ultra: IO 0x1800-0x180F, IRQ 0x5
+advansys: advansys_detect: unknown bus type: 4
Somehow I've messed up the IRQ.
The unknown bus type is just a minor oversight -- i ripped out the
handling of PCI bus types from advansys_detect, but let it try to probe
for them anyway, which it no longer knows how to handle.
> I'd be glad to attempt the patches again. It would be easier for me if you
> sent me the raw patches, if possible.
How about I send you a patch on top of the advansys.c you got from that
git tree?
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-07-17 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 20:28 advansys cleanup Matthew Wilcox
2007-07-16 22:41 ` [PATCH 1/4] advansys: Create advansys_board_found() Matthew Wilcox
2007-07-16 22:41 ` [PATCH 2/4] advansys: Clean up proc_info implementation Matthew Wilcox
2007-07-16 22:41 ` [PATCH 3/4] advansys: Convert to pci_register_driver interface Matthew Wilcox
2007-07-16 22:41 ` [PATCH 4/4] advansys: Move to scsi hotplug initialisation model Matthew Wilcox
2007-07-17 14:24 ` advansys cleanup Matthew Wilcox
2007-07-17 15:36 ` Ken Witherow
2007-07-17 16:37 ` Matthew Wilcox [this message]
2007-07-17 20:05 ` Ken Witherow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717163754.GD14791@parisc-linux.org \
--to=matthew@wil.cx \
--cc=hch@infradead.org \
--cc=jeffreyfreeman@syncleus.com \
--cc=ken@krwtech.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.