From: Matthew Wilcox <matthew@wil.cx>
To: Richard Hirst <rhirst@levanta.com>
Cc: linux-scsi@vger.kernel.org
Subject: sim710_device_remove seems buggy
Date: Tue, 17 Jul 2007 10:55:21 -0600 [thread overview]
Message-ID: <20070717165521.GE14791@parisc-linux.org> (raw)
Hi Richard,
I was looking for inspiration in sim710 when I found what appears to me
to be a bug. Your implementation of sim710_device_remove does:
sim710_device_remove(struct device *dev)
{
struct Scsi_Host *host = dev_to_shost(dev);
Now, this is going to be called with the struct device corresponding to
either the MCA or EISA device which is the *parent* of the shost.
dev_to_shost only looks upwards in the tree, so it will never find the
shost.
Unfortunately, I don't have a good idea about how to solve this. The
least lame perhaps is to have separate routines for EISA and MCA
devices, each of which passes the shost to this routine.
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next reply other threads:[~2007-07-17 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 16:55 Matthew Wilcox [this message]
2007-07-17 18:52 ` sim710_device_remove seems buggy Matthew Wilcox
2007-07-17 18:57 ` James Bottomley
2007-07-17 19:38 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717165521.GE14791@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-scsi@vger.kernel.org \
--cc=rhirst@levanta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.