All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Brian De Wolf <bldewolf@csupomona.edu>
Cc: linux-scsi@vger.kernel.org,
	device-mapper development <dm-devel@redhat.com>,
	sekharan@us.ibm.com, Mike Anderson <andmike@us.ibm.com>
Subject: [PATCH] dm-mpath-rdac: don't stomp on a request's transfer bit.
Date: Tue, 17 Jul 2007 14:07:06 -0700	[thread overview]
Message-ID: <20070717210706.GA2277@plap.qlogic.org> (raw)
In-Reply-To: <20070713023743.GA5350@us.ibm.com>

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
---

	On Thu, 12 Jul 2007, Mike Anderson wrote:

	> Copying this mail to linux-scsi and Ccing Andrew Vasquez to possibly
	> provide input on the Qlogic behavior.
	...

	> > > Jul 12 17:11:15 jimbo kernel: qla2xxx 0000:02:01.1: ISP System Error - mbx1=0h
	> > > mbx2=8012h mbx3=8002h.
	> > > Jul 12 17:11:15 jimbo kernel: qla2xxx 0000:02:01.1: Firmware has been previously
	> > > dumped (ffffc2000171d000) -- ignoring request...
	> > > Jul 12 17:11:16 jimbo kernel: qla2xxx 0000:02:01.1: Performing ISP error
	> > > recovery - ha= ffff81007e85c530.

	So what's happening here is the firmware is detecting a Xfer-ready
	from the storage when in fact the data-direction for a mode-select
	should be a write (DATA_OUT).

	The following patch fixes the problem (typo).  Verified by Brian, as
	well.

diff --git a/drivers/md/dm-mpath-rdac.c b/drivers/md/dm-mpath-rdac.c
index 8b776b8..16b1613 100644
--- a/drivers/md/dm-mpath-rdac.c
+++ b/drivers/md/dm-mpath-rdac.c
@@ -292,7 +292,7 @@ static struct request *get_rdac_req(struct rdac_handler *h,
 	rq->end_io_data = h;
 	rq->timeout = h->timeout;
 	rq->cmd_type = REQ_TYPE_BLOCK_PC;
-	rq->cmd_flags = REQ_FAILFAST | REQ_NOMERGE;
+	rq->cmd_flags |= REQ_FAILFAST | REQ_NOMERGE;
 	return rq;
 }
 


  parent reply	other threads:[~2007-07-17 21:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13  1:35 dm-mpath-rdac.patch problem Brian De Wolf
2007-07-13  2:06 ` Chandra Seetharaman
2007-07-13  2:37   ` Mike Anderson
2007-07-13 16:12     ` [dm-devel] " Andrew Vasquez
2007-07-13 19:13       ` Brian De Wolf
2007-07-13 19:33       ` Brian De Wolf
2007-07-17 21:07     ` Andrew Vasquez [this message]
2007-07-20 23:05       ` [PATCH] dm-mpath-rdac: don't stomp on a request's transfer bit Brian De Wolf
2007-07-21  1:25         ` Chandra Seetharaman
2007-07-21 16:45         ` Alasdair G Kergon
2007-07-21  5:56       ` Chandra Seetharaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070717210706.GA2277@plap.qlogic.org \
    --to=andrew.vasquez@qlogic.com \
    --cc=andmike@us.ibm.com \
    --cc=bldewolf@csupomona.edu \
    --cc=dm-devel@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sekharan@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.