From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936958AbXGQXZG (ORCPT ); Tue, 17 Jul 2007 19:25:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763933AbXGQXYy (ORCPT ); Tue, 17 Jul 2007 19:24:54 -0400 Received: from atlas.informatik.uni-freiburg.de ([132.230.150.3]:40929 "EHLO atlas.informatik.uni-freiburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762378AbXGQXYy (ORCPT ); Tue, 17 Jul 2007 19:24:54 -0400 Date: Wed, 18 Jul 2007 01:24:46 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Avi Kivity , linux-kernel@vger.kernel.org Subject: a52b1752c07 broke !SMP: error: implicit declaration of function `WARN_ON' Message-ID: <20070717232446.GA20140@lala> Mail-Followup-To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Avi Kivity , linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.16 (2007-06-11) Organization: Universitaet Freiburg, Institut f. Informatik Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello, kernel/timer.c (and some others as arch/arm/kernel/irq.c) include , but not a52b1752c07 introduces usage of the WARN_ON macro in , but doesn't pull in . ( is not enough, at least for arm, because WARN_ON uses printk there.) The obvious options are: 1) include in , maybe conditioned by !SMP 2) include in all includers of 3) remove the WARN_ONs introduced by a52b1752c07. WARN_ON is used in an inline function that isn't used in every file including , so maybe updating the compiler might make the effort for 2) smaller!? (I'm using gcc 3.4.4) Best regards Uwe -- Uwe Kleine-König $ dc -e "5735816763073014741799356604682P"