From: Al Viro <viro@ftp.linux.org.uk>
To: Uwe Kleine-K?nig <ukleinek@informatik.uni-freiburg.de>,
Avi Kivity <avi@qumranet.com>,
linux-kernel@vger.kernel.org
Subject: Re: a52b1752c07 broke !SMP: error: implicit declaration of function `WARN_ON'
Date: Wed, 18 Jul 2007 00:54:00 +0100 [thread overview]
Message-ID: <20070717235400.GQ21668@ftp.linux.org.uk> (raw)
In-Reply-To: <20070717232446.GA20140@lala>
On Wed, Jul 18, 2007 at 01:24:46AM +0200, Uwe Kleine-K?nig wrote:
> Hello,
>
> kernel/timer.c (and some others as arch/arm/kernel/irq.c) include
> <linux/smp.h>, but not <linux/kernel.h>
>
> a52b1752c07 introduces usage of the WARN_ON macro in <linux/smp.h>, but
> doesn't pull in <linux/kernel.h>. (<asm/bug.h> is not enough, at least
> for arm, because WARN_ON uses printk there.)
>
> The obvious options are:
>
> 1) include <linux/kernel.h> in <linux/smp.h>, maybe conditioned by !SMP
> 2) include <linux/kernel.h> in all includers of <linux/smp.h>
> 3) remove the WARN_ONs introduced by a52b1752c07.
>
> WARN_ON is used in an inline function that isn't used in every file
> including <linux/smp.h>, so maybe updating the compiler might make
> the effort for 2) smaller!? (I'm using gcc 3.4.4)
4) turn the sucker into macro
next prev parent reply other threads:[~2007-07-17 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 23:24 a52b1752c07 broke !SMP: error: implicit declaration of function `WARN_ON' Uwe Kleine-König
2007-07-17 23:54 ` Al Viro [this message]
2007-07-18 4:16 ` [PATCH] UP: smp_call_function_single() must warn on irqs_disabled() Satyam Sharma
2007-07-18 4:49 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717235400.GQ21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.