From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] block: factor out bio_check_eod() Date: Wed, 18 Jul 2007 13:34:50 +0200 Message-ID: <20070718113450.GP11657@kernel.dk> References: <18006.38689.818186.221707@notabene.brown> <18010.12472.209452.148229@notabene.brown> <20070530093503.GA15559@kernel.dk> <20070718105655.GB22374@htj.dyndns.org> <20070718105946.GC22374@htj.dyndns.org> <20070718110619.GM11657@kernel.dk> <469DF700.4030806@gmail.com> <20070718113103.GO11657@kernel.dk> <469DFA75.6070205@gmail.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <469DFA75.6070205@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Tejun Heo Cc: David Chinner , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Phillip Susi , Andreas Dilger List-Id: dm-devel.ids On Wed, Jul 18 2007, Tejun Heo wrote: > Jens Axboe wrote: > > On Wed, Jul 18 2007, Tejun Heo wrote: > >> Jens Axboe wrote: > >>> On Wed, Jul 18 2007, Tejun Heo wrote: > >>>> End of device check is done twice in __generic_make_request() and it's > >>>> fully inlined each time. Factor out bio_check_eod(). > >>> Tejun, yeah I should seperate the cleanups and put them in the upstream > >>> branch. Will do so and add your signed-off to both of them. > >>> > >> Would they be different from the one I just posted? No big deal either > >> way. I'm just basing the zero-length barrier on top of these patches. > >> Oh well, the changes are trivial anyway. > > > > This one ended up being the same, but in the first one you missed some > > of the cleanups. I ended up splitting the patch some more though, see > > the series: > > > > http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=barrier > > Alright, will base on 662d5c5e6afb79d05db5563205b809c0de530286. Thanks. 1781c6a39fb6e31836557618c4505f5f7bc61605, no? Unless you want to rewrite it completely :-) -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932675AbXGRLfg (ORCPT ); Wed, 18 Jul 2007 07:35:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759191AbXGRLfT (ORCPT ); Wed, 18 Jul 2007 07:35:19 -0400 Received: from brick.kernel.dk ([80.160.20.94]:6998 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758936AbXGRLfQ (ORCPT ); Wed, 18 Jul 2007 07:35:16 -0400 Date: Wed, 18 Jul 2007 13:34:50 +0200 From: Jens Axboe To: Tejun Heo Cc: Neil Brown , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, David Chinner , Phillip Susi , Stefan Bader , Andreas Dilger Subject: Re: [PATCH] block: factor out bio_check_eod() Message-ID: <20070718113450.GP11657@kernel.dk> References: <18006.38689.818186.221707@notabene.brown> <18010.12472.209452.148229@notabene.brown> <20070530093503.GA15559@kernel.dk> <20070718105655.GB22374@htj.dyndns.org> <20070718105946.GC22374@htj.dyndns.org> <20070718110619.GM11657@kernel.dk> <469DF700.4030806@gmail.com> <20070718113103.GO11657@kernel.dk> <469DFA75.6070205@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <469DFA75.6070205@gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18 2007, Tejun Heo wrote: > Jens Axboe wrote: > > On Wed, Jul 18 2007, Tejun Heo wrote: > >> Jens Axboe wrote: > >>> On Wed, Jul 18 2007, Tejun Heo wrote: > >>>> End of device check is done twice in __generic_make_request() and it's > >>>> fully inlined each time. Factor out bio_check_eod(). > >>> Tejun, yeah I should seperate the cleanups and put them in the upstream > >>> branch. Will do so and add your signed-off to both of them. > >>> > >> Would they be different from the one I just posted? No big deal either > >> way. I'm just basing the zero-length barrier on top of these patches. > >> Oh well, the changes are trivial anyway. > > > > This one ended up being the same, but in the first one you missed some > > of the cleanups. I ended up splitting the patch some more though, see > > the series: > > > > http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=barrier > > Alright, will base on 662d5c5e6afb79d05db5563205b809c0de530286. Thanks. 1781c6a39fb6e31836557618c4505f5f7bc61605, no? Unless you want to rewrite it completely :-) -- Jens Axboe