From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Cc: netdev@vger.kernel.org, rpurdie@rpsys.net
Subject: Re: [PATCH] Add a network activity LED trigger
Date: Wed, 18 Jul 2007 14:41:22 +0100 [thread overview]
Message-ID: <20070718144122.00f28346@oldman> (raw)
In-Reply-To: <200707181527.38895.florian.fainelli@telecomint.eu>
On Wed, 18 Jul 2007 15:27:38 +0200
Florian Fainelli <florian.fainelli@telecomint.eu> wrote:
> Hi all,
>
> This patch adds a new LED trigger, based on network activity. It gathers
> activity from net/core/dev.c and can be used as a LED trigger by
> specifying "network-activity". Further version should allow the user to
> specify the network interface to bind a LED to. This trigger is a "simple"
> trigger as defined by the LED subsystem.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@telecomint.eu>
> --
You are slowing down the network receive path even if LED is not used.
Doing mod_timer() is expensive, on a busy system you would be adding
another lock roundtrip and list operation for each incoming packet.
prev parent reply other threads:[~2007-07-18 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 13:27 [PATCH] Add a network activity LED trigger Florian Fainelli
2007-07-18 13:33 ` Patrick McHardy
2007-07-18 13:44 ` Florian Fainelli
2007-07-18 13:54 ` Patrick McHardy
2007-07-18 14:10 ` Richard Purdie
2007-07-18 14:14 ` Patrick McHardy
2007-07-18 22:22 ` David Miller
2007-07-18 13:41 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718144122.00f28346@oldman \
--to=shemminger@linux-foundation.org \
--cc=florian.fainelli@telecomint.eu \
--cc=netdev@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.