Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 17 Jul 2007 09:10:18 +0200
Soeren Sonnenburg <kernel@nn7.de> wrote:

> the attached minimally intrusive patch is based on Matthew Garret's
> patch 'Make appletouch shut up when it has nothing to say' patches (e.g.
> http://lkml.org/lkml/2007/5/13/117): Matthews description follows /
> second paragraph lists my additional changes.
> 
> The appletouch geyser3 devices found in the Intel Macs (and possibly some later 
> PPC ones?) send a constant stream of packets after the first touch. This 
> results in the kernel waking up around once every couple of milliseconds 
> to process them, making it almost impossible to spend any significant 
> period of time in C3 state on a dynamic HZ kernel. Sending the mode 
> initialization code makes the device shut up until it's touched again. 
> This patch does so after receiving 10 packets with no interesting 
> content.
> 
> In addition it now empties the work queue via cancel_work_sync on module
> exit, keeps all error checking and only reports BTN_LEFT presses if bit
> 1 in the status byte (last byte in packet) is set. This fixes the random
> left clicks issue. Furthermore it invalidates touchpad data before the
> mode switch, which fixes the touchpad runs amok issue.

Please feed this through scripts/checkpatch.pl and consider addressing
all the things which it reports.