From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] No longer reviewing random hwmon patches
Date: Wed, 18 Jul 2007 18:14:09 +0000 [thread overview]
Message-ID: <20070718201409.1c1077d0@hyperion.delvare> (raw)
Hi all,
Twice in the past 2 weeks, I have been criticized for being too
demanding in my hwmon patch reviews. I have been told that I was
wasting developers' time and taking the fun away from them. Well, I am
also no longer having fun reviewing patches when I am "rewarded" this
way. Not that reviewing patches is really fun to start with, you
usually don't receive much thank nor praise, but receiving criticism is
going one step too far.
It has been suggested that I should review patches differently and
accept more divergence from what I consider the right way. This isn't
going to happen, sorry. Given that I am not paid for the job, nobody
gets to tell me which patches I should review and how. But I also don't
want to cause contributors to leave the project.
As a consequence, I have decided to change my behavior with regards to
the patches which are posted to the lm-sensors list. I will no longer
review random patches. I will only review patches meeting any of the
following conditions:
* I asked for that patch.
* The patch is for a hwmon driver I am maintaining.
* The author explicitly asked me to review his/her work, and I feel
like it.
* Mark asked me to review the patch.
Hopefully this will prevent further tensions from arising.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2007-07-18 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 18:14 Jean Delvare [this message]
2007-07-18 19:27 ` [lm-sensors] No longer reviewing random hwmon patches Hans-Jürgen Koch
2007-07-18 19:57 ` Roger Lucas
2007-07-18 21:09 ` Jean Delvare
2007-07-19 6:37 ` David Hubbard
2007-07-19 9:07 ` JGong
2007-07-19 17:27 ` Till Harbaum / Lists
2007-07-30 3:12 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718201409.1c1077d0@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.