From: "Shawn O. Pearce" <spearce@spearce.org>
To: Adam Roben <aroben@apple.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add commit.editor configuration variable
Date: Thu, 19 Jul 2007 02:23:02 -0400 [thread overview]
Message-ID: <20070719062302.GG32566@spearce.org> (raw)
In-Reply-To: <47EE39C7-0D57-48EC-B5A0-C10E49997E32@apple.com>
Adam Roben <aroben@apple.com> wrote:
> On Jul 18, 2007, at 11:08 PM, Junio C Hamano wrote:
>
> >I do not think commit.editor is a good name. Wouldn't we want
> >that customized editor for "git tag -a" as well? Probably
> >core.editor would come nicely next to core.pager we already
> >have.
>
> I considered core.editor, but if it's an editor that is *only*
> used for commit messages then that seems to be a too-general name, and
> something like core.commit_message_editor seemed far too long. Any
> suggestions?
>
> I had forgotten about "git tag -a" -- I will add support for that
> as well.
We only launch an editor for three reasons: commit messages, tag
messages and git-rebase -i. If we were to ever add a new editor
using thingy, odds are the user would want the same editor by
default for that too.
So please, core.editor, and also use it in git-rebase--interactive.
--
Shawn.
next prev parent reply other threads:[~2007-07-19 6:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 5:39 [PATCH] Add commit.editor configuration variable Adam Roben
2007-07-19 6:08 ` Junio C Hamano
2007-07-19 6:17 ` Adam Roben
2007-07-19 6:23 ` Shawn O. Pearce [this message]
2007-07-19 6:53 ` Junio C Hamano
2007-07-19 9:54 ` Johannes Schindelin
2007-07-19 18:24 ` [PATCH] Add git-sh-setup::set_editor() Adam Roben
2007-07-19 18:46 ` Johannes Schindelin
2007-07-19 19:26 ` David Kastrup
2007-07-19 21:10 ` [PATCH] Print an error when falling back to vi on a dumb terminal Adam Roben
2007-07-19 21:19 ` Johannes Schindelin
2007-07-20 0:15 ` Junio C Hamano
2007-07-20 0:28 ` [PATCH] Add core.editor configuration variable Adam Roben
2007-07-20 5:09 ` [PATCH] Add GIT_EDITOR environment variable and " Adam Roben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719062302.GG32566@spearce.org \
--to=spearce@spearce.org \
--cc=aroben@apple.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.