From: David Teigland <teigland@redhat.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix memory leak in dlm_add_member() when dlm_node_weight() returns less than zero
Date: Thu, 19 Jul 2007 08:20:03 -0500 [thread overview]
Message-ID: <20070719132003.GA782@redhat.com> (raw)
In-Reply-To: <200707190027.43195.jesper.juhl@gmail.com>
On Thu, Jul 19, 2007 at 12:27:43AM +0200, Jesper Juhl wrote:
> Greetings,
>
> There's a memory leak in fs/dlm/member.c::dlm_add_member().
>
> If "dlm_node_weight(ls->ls_name, nodeid)" returns < 0, then
> we'll return without freeing the memory allocated to the (at
> that point yet unused) 'memb'.
> This patch frees the allocated memory in that case and thus
> avoids the leak.
Yep, thanks.
Dave
next prev parent reply other threads:[~2007-07-19 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 22:27 [PATCH] Fix memory leak in dlm_add_member() when dlm_node_weight() returns less than zero Jesper Juhl
2007-07-19 13:20 ` David Teigland [this message]
2007-07-19 15:48 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719132003.GA782@redhat.com \
--to=teigland@redhat.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.