From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [Cbe-oss-dev] [patch 11/13] cell: driver for DDR2 memory on AXON
Date: Thu, 19 Jul 2007 16:49:27 +0200 [thread overview]
Message-ID: <200707191649.27976.arnd@arndb.de> (raw)
In-Reply-To: <20070719101230.GA4553@lst.de>
On Thursday 19 July 2007, Christoph Hellwig wrote:
>
> > None of these seems to make any difference whatsoever, except for BLKBSZGET
> > returning non-zero on a ramdisk or dcssblk device. I think we'd be best
> > off removing bd_block_size from the kernel altogether, and I'll remove
> > it from the axon-ram driver now.
>
> Yes, please. I even have patches that only pass struct gendisk to block
> device ->open, so this couldn't work anymore anyway. And yes, the
> ramdisk driver is doing some really odd things.
Any suggestion on what BLKBSZGET should return?
1) blocksize = 0 (same as it does already for most devices)
2) return -EINVAL
3) same as BLKSSZGET
4) return -ENOTTY
It probably doesn't matter much as any user of BLKBSZGET is
already broken, but it would be good to do the right thing
since it is a documented interface.
Arnd <><
next parent reply other threads:[~2007-07-19 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070718160439.723093835@arndb.de>
[not found] ` <200707190048.09686.arnd@arndb.de>
[not found] ` <20070719101230.GA4553@lst.de>
2007-07-19 14:49 ` Arnd Bergmann [this message]
2007-07-19 15:15 ` [Cbe-oss-dev] [patch 11/13] cell: driver for DDR2 memory on AXON Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707191649.27976.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.