All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen.puncer@telargo.com>
To: Sylvain Munaut <tnt@246tNt.com>
Cc: Linux PPC Mailing List <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: [PATCH] powerpc: mpc5200 low power mode, .globl fix
Date: Fri, 20 Jul 2007 12:55:50 +0200	[thread overview]
Message-ID: <20070720105550.GA1385@moe.telargo.com> (raw)
In-Reply-To: <11847043512142-git-send-email-tnt@246tNt.com>

flush_data_cache doesn't need to be global, and can cause problems.
Thanks to Milton Miller for noticing this.


Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
---
 arch/powerpc/platforms/52xx/lite5200_sleep.S |    1 -
 1 file changed, 1 deletion(-)

Index: work-powerpc.git/arch/powerpc/platforms/52xx/lite5200_sleep.S
===================================================================
--- work-powerpc.git.orig/arch/powerpc/platforms/52xx/lite5200_sleep.S
+++ work-powerpc.git/arch/powerpc/platforms/52xx/lite5200_sleep.S
@@ -400,7 +400,6 @@ restore_regs:
  * Flush data cache
  * Do this by just reading lots of stuff into the cache.
  */
-        .globl flush_data_cache
 flush_data_cache:
 	lis	r3,CONFIG_KERNEL_START@h
 	ori	r3,r3,CONFIG_KERNEL_START@l

  reply	other threads:[~2007-07-20 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-17 20:32 [PATCH] powerpc: mpc5200 low power mode Sylvain Munaut
2007-07-20 10:55 ` Domen Puncer [this message]
2007-07-20 15:09   ` [PATCH] powerpc: mpc5200 low power mode, .globl fix Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070720105550.GA1385@moe.telargo.com \
    --to=domen.puncer@telargo.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=tnt@246tNt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.