All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Michael Wu <flamingice@sourmilk.net>,
	cebbert@redhat.com, linville@redhat.com,
	linux-wireless@vger.kernel.org
Subject: Re: p54usb: Don't run DMA off code segment
Date: Fri, 20 Jul 2007 10:37:13 -0400	[thread overview]
Message-ID: <20070720143713.GD7428@tuxdriver.com> (raw)
In-Reply-To: <20070719222716.e4152774.zaitcev@redhat.com>

On Thu, Jul 19, 2007 at 10:27:16PM -0700, Pete Zaitcev wrote:
> On Wed, 18 Jul 2007 00:48:31 -0700, Michael Wu <flamingice@sourmilk.n=
et> wrote:
>=20
> > On Monday 16 July 2007 23:10, Pete Zaitcev wrote:
> > > +=A0=A0=A0=A0=A0=A0=A0if ((err =3D p54u_bulk_msg(priv, P54U_PIPE_=
DATA, buf, 4)) !=3D 0) {
> > Please follow the style used elsewhere in this function and do it l=
ike:
> >=20
> >   err =3D p54u_bulk_msg(priv, P54U_PIPE_DATA, buf, 4);
> >   if (err) {
> >=20
> > The rest of the patch looks fine. Thanks for fixing this.
>=20
> How about this, then?

<snip>

That is exactly the way I committed it.  Thanks, Pete!

John
--=20
John W. Linville
linville@tuxdriver.com
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2007-07-20 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-17  6:10 p54usb: Don't run DMA off code segment Pete Zaitcev
2007-07-18  7:48 ` Michael Wu
2007-07-20  5:27   ` Pete Zaitcev
2007-07-20 14:37     ` John W. Linville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070720143713.GD7428@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=cebbert@redhat.com \
    --cc=flamingice@sourmilk.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@redhat.com \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.