From: meyering@sourceware.org <meyering@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/config/config.c
Date: Fri, 20 Jul 2007 15:30:38 -0000 [thread overview]
Message-ID: <20070720152640.7952.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: meyering at sourceware.org 2007-07-20 15:26:39
Modified files:
. : WHATS_NEW
lib/config : config.c
Log message:
In _line_append, use "sizeof buf - 1" rather than equivalent "4095"
* lib/config/config.c:
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.663&r2=1.664
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/config/config.c.diff?cvsroot=lvm2&r1=1.60&r2=1.61
--- LVM2/WHATS_NEW 2007/07/20 15:22:45 1.663
+++ LVM2/WHATS_NEW 2007/07/20 15:26:39 1.664
@@ -1,4 +1,5 @@
Version 2.02.28 -
+ In _line_append, use "sizeof buf - 1" rather than equivalent "4095"
Introduce is_same_inode macro, now including a comparison of st_dev.
Don't leak a file descriptor in _lock_file(), when flock fails.
Add SUN's LDOM virtual block device to filters
--- LVM2/lib/config/config.c 2007/07/08 22:51:20 1.60
+++ LVM2/lib/config/config.c 2007/07/20 15:26:39 1.61
@@ -367,8 +367,8 @@
int n;
va_start(ap, fmt);
- n = vsnprintf(&buf[0], 4095, fmt, ap);
- if (n < 0 || n > 4095) {
+ n = vsnprintf(&buf[0], sizeof buf - 1, fmt, ap);
+ if (n < 0 || n > sizeof buf - 1) {
log_error("vsnprintf failed for config line");
return 0;
}
next reply other threads:[~2007-07-20 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 15:30 meyering [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-21 13:23 LVM2 ./WHATS_NEW lib/config/config.c zkabelac
2010-12-20 13:53 zkabelac
2010-11-30 22:23 zkabelac
2008-06-03 17:51 agk
2007-07-08 22:51 agk
2007-03-08 19:22 agk
2007-01-17 16:22 agk
2006-11-16 17:36 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720152640.7952.qmail@sourceware.org \
--to=meyering@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.