From: Andrew Morton <akpm@linux-foundation.org>
To: sukadev@us.ibm.com
Cc: linux-kernel@vger.kernel.org,
Containers <containers@lists.osdl.org>,
Oleg Nesterov <oleg@tv-sign.ru>,
Pavel Emelianov <xemul@openvz.org>
Subject: Re: [PATCH 4/5] [V2] Define is_global_init() and is_container_init()
Date: Fri, 20 Jul 2007 15:41:13 -0700 [thread overview]
Message-ID: <20070720154113.db9fb8a4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070719072158.GD28216@us.ibm.com>
On Thu, 19 Jul 2007 00:21:58 -0700
sukadev@us.ibm.com wrote:
> --- lx26-22-rc6-mm1a.orig/kernel/pid.c 2007-07-16 12:55:15.000000000 -0700
> +++ lx26-22-rc6-mm1a/kernel/pid.c 2007-07-16 13:10:48.000000000 -0700
> @@ -69,6 +69,13 @@ struct pid_namespace init_pid_ns = {
> .last_pid = 0,
> .child_reaper = &init_task
> };
> +EXPORT_SYMBOL(init_pid_ns);
> +
> +int is_global_init(struct task_struct *tsk)
> +{
> + return tsk == init_pid_ns.child_reaper;
> +}
> +EXPORT_SYMBOL(is_global_init);
I don't immediately see why init_pid_ns was exported to modules.
It would need to be exported if is_global_init() was made static inline in a
header (which seems like a sensible thing to do), but it wasn't.
next prev parent reply other threads:[~2007-07-20 22:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 7:12 [PATCH 0/5][V2] Misc helper patches for pid namespaces sukadev
2007-07-19 7:19 ` [PATCH 1/5] [V2] Define and use task_active_pid_ns() wrapper sukadev
2007-07-19 7:20 ` [PATCH 2/5] [V2] Rename child_reaper() function sukadev
2007-07-19 7:20 ` [PATCH 3/5] [V2] Use task_pid() to find leader's pid sukadev
2007-07-19 7:21 ` [PATCH 4/5] [V2] Define is_global_init() and is_container_init() sukadev
2007-07-20 22:41 ` Andrew Morton [this message]
2007-07-21 3:02 ` sukadev
2007-07-19 7:22 ` [PATCH 5/5] [V2] Move alloc_pid() to copy_process() sukadev
[not found] ` <20070719072240.GE28216-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-07-19 7:44 ` Pavel Emelyanov
2007-07-19 7:44 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720154113.db9fb8a4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=sukadev@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.