From: FUJITA Tomonori <tomof@acm.org>
To: James.Bottomley@SteelEye.com
Cc: fujita.tomonori@lab.ntt.co.jp, Jens.Axboe@oracle.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] bsg: fix bsg_register_queue error path
Date: Sat, 21 Jul 2007 10:14:51 +0900 [thread overview]
Message-ID: <20070721100706X.tomof@acm.org> (raw)
In-Reply-To: <1184968210.3455.66.camel@localhost.localdomain>
From: James Bottomley <James.Bottomley@SteelEye.com>
Subject: [PATCH] bsg: fix bsg_register_queue error path
Date: Fri, 20 Jul 2007 16:50:10 -0500
> unfortunately, if IS_ERR(class_dev) is true, that means class_dev isn't
> null and the check in the error leg is pointless ... it's also asking
> for trouble to request unregistration of a device we haven't actually
> created (although it works currently). Fix by using explicit gotos and
> unregisters.
ACK, thanks.
prev parent reply other threads:[~2007-07-21 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 21:50 [PATCH] bsg: fix bsg_register_queue error path James Bottomley
2007-07-21 1:14 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070721100706X.tomof@acm.org \
--to=tomof@acm.org \
--cc=James.Bottomley@SteelEye.com \
--cc=Jens.Axboe@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.