From: Andi Kleen <ak@suse.de>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
joachim.deguara@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: use apic core id bits for core nums
Date: Sat, 21 Jul 2007 10:22:47 +0200 [thread overview]
Message-ID: <200707211022.47859.ak@suse.de> (raw)
In-Reply-To: <86802c440707210056s745d44f1jc6437064741299eb@mail.gmail.com>
On Saturday 21 July 2007 09:56:15 Yinghai Lu wrote:
> please check my version, we should use core id bits instead.
>
> it should replace
> [PATCH for review] [37/48] x86_64: make k8topology multi-core aware
Yes, you're right the patch is not good. It should probably use
information from the regular CPU setup code, not touch cpuid
directly
I'll drop it for now
-Andi
next prev parent reply other threads:[~2007-07-21 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 7:56 [PATCH] x86_64: use apic core id bits for core nums Yinghai Lu
2007-07-21 8:22 ` Andi Kleen [this message]
2007-07-21 11:21 ` Yinghai Lu
2007-07-21 12:28 ` Andi Kleen
2007-07-22 1:36 ` Yinghai Lu
2007-07-23 19:20 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707211022.47859.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=joachim.deguara@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.