From: Sam Ravnborg <sam@ravnborg.org>
To: Andi Kleen <andi@firstfloor.org>, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>,
drbd-user@linbit.com
Subject: Re: [DRIVER SUBMISSION] DRBD wants to go mainline
Date: Sun, 22 Jul 2007 10:52:17 +0200 [thread overview]
Message-ID: <20070722085217.GA27849@uranus.ravnborg.org> (raw)
In-Reply-To: <20070722060925.GD18326@mail.linbit.com>
> there is just one logical piece, the drbd module...
> it is all in its own subdirectory.
For review purposes the split is often file based.
Something along the lines of:
Makefile + Kconfig
include/linux/drdb* <= why 5 files for one module?
drdb_main.c
drdb_req.{c+h}
etc..
So essentially smaller pieces that can be revied but when ready for inclusion
it should go in as _one_ commit to avoid breaking bisect.
But please finish off all the CodingStyle issue before submission so the
review can concentrate on the actual content.
Quickly browsing drdb_int.h shows that there are a few issues yet to sort out.
typedef usage, funny macros, volatile etc.
Sam
next prev parent reply other threads:[~2007-07-22 8:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 20:38 [DRIVER SUBMISSION] DRBD wants to go mainline Lars Ellenberg
2007-07-21 21:17 ` Jan Engelhardt
2007-07-21 22:43 ` Lars Ellenberg
2007-07-22 9:06 ` Jan Engelhardt
2007-07-22 14:03 ` Lars Ellenberg
2007-07-27 18:46 ` Pavel Machek
2007-07-30 19:35 ` Lars Ellenberg
2007-07-30 19:41 ` Jan Engelhardt
2007-07-21 21:34 ` Jesper Juhl
2007-07-21 23:50 ` Andi Kleen
2007-07-22 5:52 ` Jens Axboe
2007-07-22 13:58 ` Lars Ellenberg
2007-07-22 14:49 ` Sam Ravnborg
2007-07-22 14:56 ` Andi Kleen
2007-07-22 15:31 ` Satyam Sharma
2007-07-22 15:50 ` Satyam Sharma
2007-07-22 16:13 ` Stefan Richter
2007-07-22 6:09 ` Lars Ellenberg
2007-07-22 8:52 ` Sam Ravnborg [this message]
2007-07-22 9:05 ` Pekka Enberg
2007-07-22 9:00 ` Pekka Enberg
2007-07-23 1:32 ` Kyle Moffett
2007-07-23 8:49 ` Christoph Hellwig
2007-07-23 9:00 ` Sam Ravnborg
2007-07-23 9:01 ` Christoph Hellwig
2007-07-23 9:19 ` Sam Ravnborg
2007-07-23 11:08 ` Lars Ellenberg
2007-07-23 13:32 ` Lars Ellenberg
2007-07-23 13:37 ` Jens Axboe
2007-07-23 21:13 ` Lars Ellenberg
2007-07-23 13:40 ` Satyam Sharma
2007-07-23 21:19 ` Lars Ellenberg
2007-07-24 7:36 ` Jens Axboe
2007-07-24 23:11 ` Satyam Sharma
2007-07-25 9:46 ` Lars Ellenberg
2007-07-25 12:12 ` Satyam Sharma
2007-07-26 2:03 ` david
2007-07-26 3:43 ` Kyle Moffett
2007-07-26 9:17 ` Evgeniy Polyakov
2007-07-24 0:48 ` Kyle Moffett
2007-07-23 20:59 ` Jesper Juhl
-- strict thread matches above, loose matches on Subject: below --
2007-07-22 9:54 Tomasz Chmielewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070722085217.GA27849@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=drbd-user@linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.