From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Glauber de Oliveira Costa <gcosta@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd
Date: Sun, 22 Jul 2007 11:18:27 +0200 [thread overview]
Message-ID: <20070722091826.GA28313@one.firstfloor.org> (raw)
In-Reply-To: <46A12A3A.4020305@zytor.com>
On Fri, Jul 20, 2007 at 02:33:46PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> > On Fri, Jul 20, 2007 at 02:19:58PM -0700, H. Peter Anvin wrote:
> >> Create an inline function for clflush(), with the proper arguments,
> >> and use it instead of hard-coding the instruction.
> >>
> >> This also removes one instance of hard-coded wbinvd, based on a patch
> >> by Bauder de Oliveira Costa.
> >
> > I don't see much sense in it. CLFLUSH is not priviledged, paravirt
> > doesn't need to change and this adds just an unnecessary layer of abstraction.
>
> The main reason is that everyone seems to invoke it either incorrectly
Where is it incorrect?
-Andi
next prev parent reply other threads:[~2007-07-22 9:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 22:55 [PATCH] Use wbinvd() macro instead of raw inline assembly in .c files Glauber de Oliveira Costa
2007-07-20 11:43 ` Andi Kleen
2007-07-20 17:22 ` H. Peter Anvin
2007-07-21 7:32 ` Muli Ben-Yehuda
2007-07-20 21:19 ` [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd H. Peter Anvin
2007-07-20 21:27 ` Andi Kleen
2007-07-20 21:33 ` H. Peter Anvin
2007-07-22 9:18 ` Andi Kleen [this message]
2007-07-22 18:05 ` H. Peter Anvin
2007-07-22 19:55 ` Andi Kleen
2007-07-22 20:02 ` H. Peter Anvin
2007-07-20 23:37 ` Glauber de Oliveira Costa
2007-07-20 23:43 ` H. Peter Anvin
2007-07-21 18:11 ` Muli Ben-Yehuda
2007-07-21 19:52 ` H. Peter Anvin
2007-07-21 20:16 ` Muli Ben-Yehuda
2007-07-21 20:18 ` H. Peter Anvin
2007-07-21 20:44 ` Muli Ben-Yehuda
2007-07-21 22:09 ` H. Peter Anvin
2007-07-21 22:24 ` H. Peter Anvin
2007-07-22 4:20 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070722091826.GA28313@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=gcosta@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.