From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: New wake ups from sky2
Date: Sun, 22 Jul 2007 21:06:12 +0100 [thread overview]
Message-ID: <20070722210612.1fa32740@oldman> (raw)
In-Reply-To: <46A1CB36.5010609@m3y3r.de>
On Sat, 21 Jul 2007 11:00:38 +0200
Thomas Meyer <thomas@m3y3r.de> wrote:
> Stephen Hemminger schrieb:
> > Thomas Meyer <thomas@m3y3r.de> wrote:
> >
> >
> >> Today i did a git pull to be up to date again and i noticed in the
> >> powertop tool that i'll get this new entry
> >>
> >> 14,2% ( 9,1) <kernel core> : sky2_probe (sky2_idle)
> >>
> >> with around 10 interrupts per second.
> >>
> >> i think (i.e. i don't know and just guessing!) this commit is
> >> responsible for these wake ups:
> >>
> >> git show eb35cf60e462491249166182e3e755d3d5d91a28
> >>
> >> Author: Stephen Hemminger <shemminger@osdl.org>
> >> Date: Tue Jun 13 17:17:31 2006 +0900
> >>
> >> [PATCH] sky2: stop/start hardware idle timer on suspend/resume
> >>
> >> The resume bug was caused not by an early interrupt but because the idle
> >> timeout was not being stopped on suspend. Also disable hardware IRQ's
> >> on suspend. Will need to revisit this with hotplug?
> >>
> >> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> >> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
> >>
> >> Any ideas?
> >>
> >>
> >
> > Last version has idle timer enabled.
> > It is a tradeoff between device hanging due to lost interrupt or wasting power.
> > You can make the timeout longer by setting idle_timeout module parameter larger,
> > (or zero which will disable it).
> >
> Ok. But do you need to start the timer when no cable is plugged in, like
> in the case above?
Probably not, because risk of missed PHY interrupt is miniscule.
prev parent reply other threads:[~2007-07-22 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46A10CC3.6050909@m3y3r.de>
[not found] ` <20070720225038.7635da3f@oldman>
2007-07-21 9:00 ` New wake ups from sky2 Thomas Meyer
2007-07-22 20:06 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070722210612.1fa32740@oldman \
--to=shemminger@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.