From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 23 Jul 2007 14:22:00 +0100 (BST) Received: from localhost.localdomain ([127.0.0.1]:52676 "EHLO dl5rb.ham-radio-op.net") by ftp.linux-mips.org with ESMTP id S20022676AbXGWNV5 (ORCPT ); Mon, 23 Jul 2007 14:21:57 +0100 Received: from denk.linux-mips.net (denk.linux-mips.net [127.0.0.1]) by dl5rb.ham-radio-op.net (8.14.1/8.13.8) with ESMTP id l6NDLuhI001760; Mon, 23 Jul 2007 14:21:56 +0100 Received: (from ralf@localhost) by denk.linux-mips.net (8.14.1/8.14.1/Submit) id l6NDLudv001759; Mon, 23 Jul 2007 14:21:56 +0100 Date: Mon, 23 Jul 2007 14:21:56 +0100 From: Ralf Baechle To: "Maciej W. Rozycki" Cc: Thiemo Seufer , linux-mips@linux-mips.org Subject: Re: [PATCH] bcm1480 serial build fix Message-ID: <20070723132156.GD31040@linux-mips.org> References: <20070722075515.GB23747@networkno.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.14 (2007-02-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 15862 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk X-list: linux-mips On Mon, Jul 23, 2007 at 02:00:16PM +0100, Maciej W. Rozycki wrote: > Aren't all the bits in "bcm1480_regs.h" meant to be prefixed with > BCM1480_DUART? If these are to be the same as for the BCM1250, then they > can probably be defined "in sb1250_regs.h" unconditionally. > > These headers are a horrible mess anyway -- a single definition should be > enough to access the two DUARTs the BCM1480 seems to have... The headers are autogenerated by Broadcom; they got some header-o-matic which from a common source base will generate headers for Linux and several other operating systems by adding (C) headers etc. Which makes sorting them tricky ... Ralf