From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/11] ide-pmac: pmac_ide_tune_chipset() fixes
Date: Mon, 23 Jul 2007 23:21:11 +0200 [thread overview]
Message-ID: <200707232321.11494.bzolnier@gmail.com> (raw)
In-Reply-To: <1185141328.5439.60.camel@localhost.localdomain>
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-22 at 20:21 +0200, Bartlomiej Zolnierkiewicz wrote:
> > * Don't check check for pmif == NULL (it should never be NULL if we got here).
> >
> > * Make a local copy of the timings and set the pmif->timings[] only after
> > setting the transfer mode on the device (otherwise SELECT_DRIVE() call in
> > pmac_ide_do_setfeature() will program new timings before the transfer mode
> > is set on the device - this was pointed out by Sergei). This change makes
> > pmac_ide_tune_chipset() behavior match this of pmac_ide_{m,u}dma_enable().
> >
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
added
prev parent reply other threads:[~2007-07-23 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 18:21 [PATCH 2/11] ide-pmac: pmac_ide_tune_chipset() fixes Bartlomiej Zolnierkiewicz
2007-07-22 21:55 ` Benjamin Herrenschmidt
2007-07-23 21:21 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707232321.11494.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.