From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/11] ide-pmac: fix set_timings_mdma()
Date: Mon, 23 Jul 2007 23:21:15 +0200 [thread overview]
Message-ID: <200707232321.15308.bzolnier@gmail.com> (raw)
In-Reply-To: <1185141437.5439.62.camel@localhost.localdomain>
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-22 at 20:22 +0200, Bartlomiej Zolnierkiewicz wrote:
> > * Move adjusting of cycle time for devices providing explicit DMA cycle time
> > from pmac_ide_mdma_enable() to set_timings_mdma().
> >
> > * Remove no longer needed drive_cycle_time argument.
> >
> > * BUG() if unsupported speed argument value is passed (shouldn't happen).
> >
> > * Matching access/recovery timings always exist so remove redundant check.
> >
> > * Make set_timings_mdma() void.
> >
> > * Update pmac_ide_tune_chipset()'s comment.
> >
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
added
prev parent reply other threads:[~2007-07-23 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 18:22 [PATCH 3/11] ide-pmac: fix set_timings_mdma() Bartlomiej Zolnierkiewicz
2007-07-22 21:57 ` Benjamin Herrenschmidt
2007-07-23 21:21 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707232321.15308.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.