From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 7/11] ide: add __ide_wait_stat() helper
Date: Mon, 23 Jul 2007 23:22:31 +0200 [thread overview]
Message-ID: <200707232322.31495.bzolnier@gmail.com> (raw)
In-Reply-To: <46A4AA97.9060702@ru.mvista.com>
On Monday 23 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Split off checking of the status register from ide_wait_stat() to
> > __ide_wait_stat() helper.
>
> > * Use the new helper in ide_config_drive_speed(). The only change in the
> > functionality is that the function now fails if after 20 sec (WAIT_CMD)
> > device is still busy (BUSY_STAT bit is set) while previously instead of
> > failing the function continued with checking for the correct device status
> > (which would give the device additional 10 usec to clear BUSY_STAT bit).
>
> > * Remove stale comment for ide_config_drive_speed().
>
> > * Remove duplicate comment for ide_wait_stat() from <linux/ide.h>.
>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
prev parent reply other threads:[~2007-07-23 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 18:31 [PATCH 7/11] ide: add __ide_wait_stat() helper Bartlomiej Zolnierkiewicz
2007-07-23 13:18 ` Sergei Shtylyov
2007-07-23 21:22 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707232322.31495.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.